feat(fs): MemFs — in-memory Fs implementation for testing and in-memory trees

benches/index_block.rs

@@ -116,6 +116,7 @@ fn build_table_for_point_read(restart_interval: u8) -> BenchTable {
         0,
         Arc::new(Cache::with_capacity_bytes(1_000_000)),
         Some(Arc::new(DescriptorTable::new(8))),
+        Arc::new(lsm_tree::fs::StdFs),
         false,
         false,
         None,

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.94.0"
+channel = "1.94.1"
 components = ["rustfmt", "clippy"]

src/blob_tree/ingest.rs

@@ -227,6 +227,7 @@ impl<'a> BlobIngestion<'a> {
                     index.id,
                     index.config.cache.clone(),
                     index.config.descriptor_table.clone(),
+                    self.table.level_fs.clone(),
                     false,
                     false,
                     index.config.encryption.clone(),

src/blob_tree/mod.rs

@@ -139,7 +139,6 @@ pub struct BlobTree {
 impl BlobTree {
     pub(crate) fn open(config: Config) -> crate::Result<Self> {
         use crate::file::{BLOBS_FOLDER, fsync_directory};
-        use crate::fs::Fs;
 
         let index = crate::Tree::open(config)?;
 
@@ -425,7 +424,7 @@ impl AbstractTree for BlobTree {
             self.index.table_id_counter.clone(),
             64 * 1_024 * 1_024,
             0,
-            level_fs,
+            level_fs.clone(),
         )?
         .set_comparator(self.index.config.comparator.clone())
         .use_data_block_restart_interval(data_block_restart_interval)
@@ -545,6 +544,7 @@ impl AbstractTree for BlobTree {
                     self.index.id,
                     self.index.config.cache.clone(),
                     self.index.config.descriptor_table.clone(),
+                    level_fs.clone(),
                     pin_filter,
                     pin_index,
                     self.index.config.encryption.clone(),

src/compaction/flavour.rs

@@ -371,6 +371,7 @@ impl StandardCompaction {
 
     fn consume_writer(self, opts: &Options, dst_lvl: usize) -> crate::Result<Vec<Table>> {
         let table_base_folder = self.table_writer.base_path.clone();
+        let level_fs = self.table_writer.fs.clone();
 
         let pin_filter = opts.config.filter_block_pinning_policy.get(dst_lvl);
         let pin_index = opts.config.index_block_pinning_policy.get(dst_lvl);
@@ -386,6 +387,7 @@ impl StandardCompaction {
                     opts.tree_id,
                     opts.config.cache.clone(),
                     opts.config.descriptor_table.clone(),
+                    level_fs.clone(),
                     pin_filter,
                     pin_index,
                     opts.config.encryption.clone(),

src/config/mod.rs

@@ -216,22 +216,17 @@ impl KvSeparationOptions {
 }
 
 /// Tree configuration builder
-///
-/// The generic parameter `F` selects the filesystem backend.
-/// It defaults to [`StdFs`], so existing code that writes `Config`
-/// without a type parameter continues to work unchanged.
-pub struct Config<F: Fs = StdFs> {
+pub struct Config {
     /// Folder path
     #[doc(hidden)]
     pub path: PathBuf,
 
     /// Filesystem backend
     ///
-    // All Config fields are `#[doc(hidden)] pub` by convention — callers use
-    // builder methods or `..Default::default()`, not struct literals directly.
-    // A `with_fs()` builder will be added when call-site refactoring lands.
+    /// Defaults to [`StdFs`]. Use [`Config::with_fs`] to plug in an
+    /// alternative backend such as [`MemFs`](crate::fs::MemFs).
     #[doc(hidden)]
-    pub fs: Arc<F>,
+    pub fs: Arc<dyn Fs>,
 
     /// Per-level filesystem routing for tiered storage.
     ///
@@ -447,6 +442,32 @@ impl Config {
         }
     }
 
+    /// Sets the filesystem backend.
+    ///
+    /// Defaults to [`StdFs`]. Use [`MemFs`](crate::fs::MemFs) for
+    /// in-memory trees (testing, ephemeral indexes).
+    ///
+    /// # Example
+    ///
+    /// ```
+    /// use lsm_tree::{Config, SequenceNumberCounter};
+    /// use lsm_tree::fs::MemFs;
+    ///
+    /// let tree = Config::new(
+    ///     "/virtual/tree",
+    ///     SequenceNumberCounter::default(),
+    ///     SequenceNumberCounter::default(),
+    /// )
+    /// .with_fs(MemFs::new())
+    /// .open()
+    /// .unwrap();
+    /// ```
+    #[must_use]
+    pub fn with_fs<F: Fs>(mut self, fs: F) -> Self {
+        self.fs = Arc::new(fs);
+        self
+    }
+
     /// Opens a tree using the config.
     ///
     /// # Errors
@@ -582,7 +603,7 @@ mod tests {
     }
 }
 
-impl<F: Fs> Config<F> {
+impl Config {
     /// Returns the tables folder path and [`Fs`] backend for the given level.
     ///
     /// If [`level_routes`](Self::level_routes) has an entry covering this

src/file.rs

@@ -47,40 +47,54 @@ pub fn read_exact(file: &dyn FsFile, offset: u64, size: usize) -> std::io::Resul
     Ok(builder.freeze().into())
 }
 
-/// Atomically rewrites a file.
+/// Atomically rewrites a file via the [`Fs`] trait.
+///
+/// Writes `content` to a temporary file in the same directory, fsyncs it,
+/// then renames over `path`. This ensures readers never see a partial write.
 pub fn rewrite_atomic(path: &Path, content: &[u8], fs: &dyn Fs) -> std::io::Result<()> {
+    use crate::fs::FsOpenOptions;
+    use std::sync::atomic::{AtomicU64, Ordering};
+
+    static TEMP_SEQ: AtomicU64 = AtomicU64::new(0);
+
     #[expect(
         clippy::expect_used,
         reason = "every file should have a parent directory"
     )]
     let folder = path.parent().expect("should have a parent");
 
-    // NOTE: tempfile crate uses std::fs internally; migrating temp-file
-    // creation to Fs would require a custom implementation.
-    let mut temp_file = tempfile::NamedTempFile::new_in(folder)?;
-    temp_file.write_all(content)?;
-    temp_file.flush()?;
-    temp_file.as_file_mut().sync_all()?;
-    temp_file.persist(path)?;
-
-    // Suppress unused-variable warning on Windows where the post-persist
-    // sync block is skipped (directory fsync is unsupported).
-    let _ = &fs;
-
-    #[cfg(not(target_os = "windows"))]
-    {
-        use crate::fs::FsOpenOptions;
-
-        let file = fs.open(path, &FsOpenOptions::new().read(true))?;
+    // PID + monotonic seq gives uniqueness within a process and across
+    // concurrent processes. A crash-then-PID-reuse collision is theoretically
+    // possible but vanishingly unlikely (requires exact PID reuse AND seq
+    // counter restart to same value). lsm-tree uses exclusive file locking
+    // so the same data directory is never written by two processes.
+    let seq = TEMP_SEQ.fetch_add(1, Ordering::Relaxed);
+    let pid = std::process::id();
+    let tmp_path = folder.join(format!(".tmp_{pid}_{seq}"));
+
+    let result = (|| -> std::io::Result<()> {
+        let mut file = fs.open(
+            &tmp_path,
+            &FsOpenOptions::new().write(true).create_new(true),
+        )?;
+        file.write_all(content)?;
+        file.flush()?;
         FsFile::sync_all(&*file)?;
+        drop(file);
+        // std::fs::rename overwrites existing destinations on all platforms
+        // (Rust uses MoveFileExW with MOVEFILE_REPLACE_EXISTING on Windows).
+        fs.rename(&tmp_path, path)?;
+        Ok(())
+    })();
 
-        #[expect(
-            clippy::expect_used,
-            reason = "files should always have a parent directory"
-        )]
-        let folder = path.parent().expect("should have parent folder");
-        fs.sync_directory(folder)?;
+    if result.is_err() {
+        // Best-effort cleanup of the temp file on any failure path.
+        // Safe to call even if fs.open() failed (file never created) —
+        // remove_file will return NotFound which we ignore.
+        let _ = fs.remove_file(&tmp_path);
     }
+    result?;
+    fsync_directory(folder, fs)?;
 
     Ok(())
 }

src/file_accessor.rs

@@ -4,7 +4,8 @@
 
 use crate::GlobalTableId;
 use crate::descriptor_table::DescriptorTable;
-use crate::fs::FsFile;
+use crate::fs::{Fs, FsFile, FsOpenOptions};
+use std::path::Path;
 use std::sync::Arc;
 
 /// Allows accessing a file (either cached or pinned)
@@ -15,46 +16,87 @@ pub enum FileAccessor {
     /// This is used in case file descriptor cache is `None` (to skip cache lookups)
     File(Arc<dyn FsFile>),
 
-    /// Access to file descriptor cache
-    DescriptorTable(Arc<DescriptorTable>),
+    /// Access to file descriptor cache with [`Fs`]-based fallback for
+    /// cache misses.
+    DescriptorTable {
+        /// The FD cache.
+        table: Arc<DescriptorTable>,
+        /// Filesystem backend for opening files on cache miss.
+        fs: Arc<dyn Fs>,
+    },
 }
 
 impl FileAccessor {
     #[must_use]
     pub fn as_descriptor_table(&self) -> Option<&DescriptorTable> {
         match self {
-            Self::DescriptorTable(d) => Some(d),
+            Self::DescriptorTable { table, .. } => Some(table),
             Self::File(_) => None,
         }
     }
 
-    #[must_use]
-    pub fn access_for_table(&self, table_id: &GlobalTableId) -> Option<Arc<dyn FsFile>> {
+    /// Returns a cached table FD or opens the file via [`Fs`] on cache miss.
+    ///
+    /// The returned `bool` indicates whether the file descriptor was already
+    /// cached (`true`) or freshly opened (`false`).
+    pub fn get_or_open_table(
+        &self,
+        table_id: &GlobalTableId,
+        path: &Path,
+    ) -> std::io::Result<(Arc<dyn FsFile>, bool)> {
         match self {
-            Self::File(fd) => Some(fd.clone()),
-            Self::DescriptorTable(descriptor_table) => descriptor_table.access_for_table(table_id),
-        }
-    }
-
-    pub fn insert_for_table(&self, table_id: GlobalTableId, fd: Arc<dyn FsFile>) {
-        if let Self::DescriptorTable(descriptor_table) = self {
-            descriptor_table.insert_for_table(table_id, fd);
+            Self::File(fd) => Ok((fd.clone(), true)),
+            Self::DescriptorTable { table, fs } => {
+                if let Some(fd) = table.access_for_table(table_id) {
+                    return Ok((fd, true));
+                }
+                let fd: Arc<dyn FsFile> =
+                    Arc::from(fs.open(path, &FsOpenOptions::new().read(true))?);
+                table.insert_for_table(*table_id, fd.clone());
+                Ok((fd, false))
+            }
         }
     }
 
-    #[must_use]
-    pub fn access_for_blob_file(&self, table_id: &GlobalTableId) -> Option<Arc<dyn FsFile>> {
+    /// Returns a cached blob file FD or opens it via [`Fs`] on cache miss.
+    ///
+    /// The returned `bool` indicates whether the file descriptor was already
+    /// cached (`true`) or freshly opened (`false`).
+    pub fn get_or_open_blob_file(
+        &self,
+        table_id: &GlobalTableId,
+        path: &Path,
+    ) -> std::io::Result<(Arc<dyn FsFile>, bool)> {
         match self {
-            Self::File(fd) => Some(fd.clone()),
-            Self::DescriptorTable(descriptor_table) => {
-                descriptor_table.access_for_blob_file(table_id)
+            Self::File(fd) => Ok((fd.clone(), true)),
+            Self::DescriptorTable { table, fs } => {
+                if let Some(fd) = table.access_for_blob_file(table_id) {
+                    return Ok((fd, true));
+                }
+                let fd: Arc<dyn FsFile> =
+                    Arc::from(fs.open(path, &FsOpenOptions::new().read(true))?);
+                table.insert_for_blob_file(*table_id, fd.clone());
+                Ok((fd, false))
             }
         }
     }
 
+    /// Pre-populates the blob file FD cache after creating a new blob file.
     pub fn insert_for_blob_file(&self, table_id: GlobalTableId, fd: Arc<dyn FsFile>) {
-        if let Self::DescriptorTable(descriptor_table) = self {
-            descriptor_table.insert_for_blob_file(table_id, fd);
+        if let Self::DescriptorTable { table, .. } = self {
+            table.insert_for_blob_file(table_id, fd);
+        }
+    }
+
+    pub fn remove_for_table(&self, table_id: &GlobalTableId) {
+        if let Self::DescriptorTable { table, .. } = self {
+            table.remove_for_table(table_id);
+        }
+    }
+
+    pub fn remove_for_blob_file(&self, table_id: &GlobalTableId) {
+        if let Self::DescriptorTable { table, .. } = self {
+            table.remove_for_blob_file(table_id);
         }
     }
 }
@@ -63,7 +105,7 @@ impl std::fmt::Debug for FileAccessor {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
         match self {
             Self::File(_) => write!(f, "FileAccessor::Pinned"),
-            Self::DescriptorTable(_) => {
+            Self::DescriptorTable { .. } => {
                 write!(f, "FileAccessor::Cached")
             }
         }