Skip to content

Re-enable test workflow on pull_request events#1578

Merged
tomer-stripe merged 2 commits intomasterfrom
fix/test-workflow-pull-request-trigger
May 8, 2026
Merged

Re-enable test workflow on pull_request events#1578
tomer-stripe merged 2 commits intomasterfrom
fix/test-workflow-pull-request-trigger

Conversation

@tomer-stripe
Copy link
Copy Markdown
Collaborator

@tomer-stripe tomer-stripe commented May 8, 2026

Summary

  • Re-adds pull_request trigger to the test workflow
  • Fixes fork PRs being unable to satisfy required test (1.26.0, ...) branch protection checks

The test workflow was changed to push-only in #1560, which inadvertently broke CI for all fork/external PRs. Fork pushes only fire workflows on the fork repo, so the required checks never appear on community PRs.

This workflow doesn't use secrets, so it's safe to run on fork PRs.

Test plan

🤖 Generated with Claude Code

The test workflow was changed to push-only in #1560, which prevents
the required `test (1.26.0, ...)` checks from running on fork PRs.
Fork pushes only trigger workflows on the fork repo, so external
contributors can never satisfy the branch protection requirements.

This workflow doesn't use secrets, so it's safe for fork PRs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Committed-By-Agent: claude
@tomer-stripe tomer-stripe requested a review from a team as a code owner May 8, 2026 01:13
@tomer-stripe tomer-stripe merged commit 754e7bc into master May 8, 2026
19 checks passed
@tomer-stripe tomer-stripe deleted the fix/test-workflow-pull-request-trigger branch May 8, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants