Skip to content

fix fixture path losing suffix after dynamic ID substitution #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomer-stripe merged 3 commits into from
May 8, 2026
+16 −1
Merged

fix fixture path losing suffix after dynamic ID substitution #1549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1748dd8
fix fixture path losing suffix after dynamic ID substitution
knQzx Apr 16, 2026
0a958ac
Merge branch 'master' into fix-fixture-path-verify
tomer-stripe May 8, 2026
437f752
Merge branch 'master' into fix-fixture-path-verify
tomer-stripe May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/parsers/parsers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ func ParsePath(httpPath string, queryRespMap map[string]gjson.Result) (string, e
newPath = append(newPath, value)
}

if len(pathParts)%2 == 0 {
// Always append the trailing path segment after the last match.
// With N matches, Split produces N+1 parts; the loop above covers
// indices 0..N-1, so the final part (index N) must be added here.
if len(pathParts) > len(matches) {
newPath = append(newPath, pathParts[len(pathParts)-1])
}

Expand Down
12 changes: 12 additions & 0 deletions pkg/parsers/parsers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,18 @@ func TestParseTwoParam(t *testing.T) {
assert.Equal(t, "/v1/charges/char_12345/capture/cust_12345", path)
}

func TestParsePathTwoParamsWithTrailing(t *testing.T) {
queryRespMap := map[string]gjson.Result{
"customer": gjson.Parse(`{"id": "cus_12345"}`),
"bank_account": gjson.Parse(`{"id": "ba_12345"}`),
}

httpPath := "/v1/customers/${customer:id}/sources/${bank_account:id}/verify"

path, _ := ParsePath(httpPath, queryRespMap)
assert.Equal(t, "/v1/customers/cus_12345/sources/ba_12345/verify", path)
}

func TestParsePathOneParamWithTrailing(t *testing.T) {
queryRespMap := map[string]gjson.Result{
"char_bender": gjson.Parse(`{"id": "char_12345"}`),
Expand Down
Loading