Skip to content

fix(file_read): filter hidden directories from glob results (#289) #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangwangbobo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(file_read): filter hidden directories from glob results (#289) #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6194685
fix: normalize path to absolute to fix cache key mismatch (fixes #345)
wangwangbobo May 30, 2026
981a882
Merge branch 'strands-agents:main' into main
wangwangbobo Jun 14, 2026
a7ec8d0
fix: derive file extension from output_format in generate_image
wangwangbobo Jun 14, 2026
f7edacc
fix(file_read): filter hidden directories from glob results (#289)
wangwangbobo Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/strands_tools/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def editor(
console = console_util.create()

try:
path = os.path.expanduser(path)
path = os.path.abspath(os.path.expanduser(path))

if not command:
raise ValueError("Command is required")
Expand Down Expand Up @@ -805,3 +805,4 @@ def editor(
"status": "error",
"content": [{"text": f"Error: {str(e)}"}],
}

2 changes: 2 additions & 0 deletions src/strands_tools/file_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,8 @@ def find_files(console: Console, pattern: str, recursive: bool = True) -> List[s

try:
matching_files = glob.glob(pattern, recursive=recursive)
# Filter out files in hidden directories
matching_files = [f for f in matching_files if not any(part.startswith(".") for part in f.split(os.sep))]
return sorted(matching_files)
except Exception as e:
console.print(
Expand Down
5 changes: 3 additions & 2 deletions src/strands_tools/generate_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,11 @@ def generate_image(tool: ToolUse, **kwargs: Any) -> ToolResult:
os.makedirs(output_dir)

i = 1
base_image_path = os.path.join(output_dir, f"{filename}.png")
ext = "jpg" if output_format == "jpeg" else output_format
base_image_path = os.path.join(output_dir, f"{filename}.{ext}")
image_path = base_image_path
while os.path.exists(image_path):
image_path = os.path.join(output_dir, f"{filename}_{i}.png")
image_path = os.path.join(output_dir, f"{filename}_{i}.{ext}")
i += 1

with open(image_path, "wb") as file:
Expand Down
Loading