-
Notifications
You must be signed in to change notification settings - Fork 7
Update Machine Instances and Templates OCP+V #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tux1980
wants to merge
55
commits into
stormshift:main
Choose a base branch
from
tux1980:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
10e04eb
Update HyperConverged.yaml
tux1980 dcb16b4
Create instancetypes
tux1980 c3503ad
Delete isar-apps/ocp-v/instancetypes
tux1980 50724de
Create README.md
tux1980 62a1438
Create README.md
tux1980 9d447fb
Create rhel-vmcit.yaml
tux1980 b48f3d5
Update rhel-vmcit.yaml
tux1980 658bbcf
Create rhel9-ds-custom.yaml
tux1980 5e65b51
Create rhel9-dv-import.yaml
tux1980 56869f0
Create rhel10-ds-custom.yaml
tux1980 868568c
Create rhel10-dv-import.yaml
tux1980 8210393
Create secret-rhel.yaml
tux1980 baba93b
Create rhel9-broadwell.yaml
tux1980 261b30c
Create rhel9-haswellv4.yaml
tux1980 ddd39d2
Create rhel10-broadwell.yaml
tux1980 581bbb5
Create rhel10-haswellv4.yaml
tux1980 84a8fad
Create rhel10-ivyv2.yaml
tux1980 5620292
Update kustomization.yaml
tux1980 5ef3f47
Update rhel-vmcit.yaml
tux1980 70496fa
Update rhel10-ds-custom.yaml
tux1980 1a98ba2
Update rhel9-ds-custom.yaml
tux1980 6d394d3
Update rhel10-ds-custom.yaml
tux1980 c8b44ef
Delete isar-apps/ocp-v/templates/rhel10-ivyv2.yaml
tux1980 ec7d794
Rename rhel-vmcit.yaml to rhel-haswell-vmcit.yaml
tux1980 1833d51
Create rhel-vmcit-broadwell.yaml
tux1980 8481e11
Create rhel-vmcit-broadwell.yaml
tux1980 6076952
Delete isar-apps/ocp-v/instancetypes/apiVersion: instancetype.kubevir…
tux1980 3eb987a
Rename rhel-vmcit-broadwell.yaml to rhel-broadwell-vmcit.yaml
tux1980 0bf8f2f
Update rhel10-ds-custom.yaml
tux1980 706177b
Update rhel9-ds-custom.yaml
tux1980 e81deae
Update rhel-broadwell-vmcit.yaml
tux1980 c05e78a
Update rhel-broadwell-vmcit.yaml
tux1980 cce2a51
Update rhel-haswell-vmcit.yaml
tux1980 cd67bed
Update rhel10-ds-custom.yaml
tux1980 e34ff0b
Update rhel9-ds-custom.yaml
tux1980 32b1843
Update rhel-broadwell-vmcit.yaml
tux1980 64ca573
Update rhel-haswell-vmcit.yaml
tux1980 7e531d5
Update rhel10-broadwell.yaml
tux1980 dff561c
Update rhel9-broadwell.yaml
tux1980 c5251b7
Update rhel10-haswellv4.yaml
tux1980 37e1a2e
Update and rename rhel9-haswellv4.yaml to rhel9-haswell.yaml
tux1980 469cd57
Rename rhel10-haswellv4.yaml to rhel10-haswell.yaml
tux1980 200d849
Update rhel10-haswell.yaml
tux1980 f60707c
Create setup.yaml
tux1980 1fba21b
Update secret-rhel.yaml
tux1980 3c82aae
Update rhel9-dv-import.yaml
tux1980 ee67f1f
Update rhel9-ds-custom.yaml
tux1980 a01f23f
Update rhel10-dv-import.yaml
tux1980 1b9bf3f
Update rhel10-ds-custom.yaml
tux1980 adb1d12
Rename rhel10-ds-custom.yaml to rhel10-ds-custom-haswell.yaml
tux1980 2ac6bb0
Rename rhel9-ds-custom.yaml to rhel9-ds-custom-haswell.yaml
tux1980 ac9ec6a
Create rhel9-ds-custom-broadwell.yaml
tux1980 b35ab3f
Create rhel10-ds-custom-broadwell.yaml
tux1980 0fbcb96
Update rhel10-ds-custom-broadwell.yaml
tux1980 f2689f8
Delete isar-apps/ocp-v/instancetypes/secret-rhel.yaml
tux1980 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| apiVersion: instancetype.kubevirt.io/v1beta1 | ||
| kind: VirtualMachineClusterInstancetype | ||
| metadata: | ||
| name: rhel-haswell-instancetype | ||
| spec: | ||
| cpu: | ||
| guest: 2 | ||
| model: "Haswell-v4" | ||
| memory: | ||
| guest: "4Gi" | ||
| nodeSelector: | ||
| usage: "rhel9-hassel" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| apiVersion: cdi.kubevirt.io/v1beta1 | ||
| kind: DataSource | ||
| metadata: | ||
| name: rhel10-haswell | ||
| namespace: openshift-virtualization-os-images | ||
| annotations: | ||
| virt.kubevirt.io/os-display-name: "RHEL 10 Custom (Haswell/Ivy)" | ||
| labels: | ||
| app.kubernetes.io/component: storage | ||
| kubevirt.io/dynamic-credentials-support: "true" | ||
| os.template.kubevirt.io/rhel10: "true" | ||
| instancetype.kubevirt.io/default-instancetype: rhel-haswell-instancetype | ||
| instancetype.kubevirt.io/default-instancetype-kind: VirtualMachineClusterInstancetype | ||
| spec: | ||
| source: | ||
| pvc: | ||
| name: rhel10-clean-base | ||
| namespace: openshift-virtualization-os-images |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| apiVersion: cdi.kubevirt.io/v1beta1 | ||
| kind: DataVolume | ||
| metadata: | ||
| name: rhel10-clean-base | ||
| namespace: openshift-virtualization-os-images | ||
| spec: | ||
| source: | ||
| registry: | ||
| url: "docker://registry.redhat.io/rhel10/rhel-guest-image:latest" | ||
| secretRef: redhat-registry-credentials | ||
| storage: | ||
| storageClassName: coe-netapp-san | ||
| accessModes: | ||
| - ReadWriteMany | ||
| resources: | ||
| requests: | ||
| storage: 30Gi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| apiVersion: cdi.kubevirt.io/v1beta1 | ||
| kind: DataSource | ||
| metadata: | ||
| name: rhel9-haswell | ||
| namespace: openshift-virtualization-os-images | ||
| annotations: | ||
| virt.kubevirt.io/os-display-name: "RHEL 9 Custom (Haswell/Ivy)" | ||
| labels: | ||
| app.kubernetes.io/component: storage | ||
| kubevirt.io/dynamic-credentials-support: "true" | ||
| os.template.kubevirt.io/rhel9: "true" | ||
| instancetype.kubevirt.io/default-instancetype: "rhel-haswell-instancetype" | ||
| instancetype.kubevirt.io/default-instancetype-kind: "VirtualMachineClusterInstancetype" | ||
| spec: | ||
| source: | ||
| pvc: | ||
| name: rhel9-clean-base | ||
| namespace: openshift-virtualization-os-images |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above but for rhel9
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. above - the ds - we need another set of Metadata - look in the Issue 312 please, there I was suppose to document. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| apiVersion: cdi.kubevirt.io/v1beta1 | ||
| kind: DataVolume | ||
| metadata: | ||
| name: rhel9-clean-base | ||
| namespace: openshift-virtualization-os-images | ||
| spec: | ||
| source: | ||
| registry: | ||
| url: "docker://registry.redhat.io/rhel9/rhel-guest-image:latest" | ||
| secretRef: redhat-registry-credentials | ||
| storage: | ||
| storageClassName: coe-netapp-san | ||
| accessModes: | ||
| - ReadWriteMany | ||
| resources: | ||
| requests: | ||
| storage: 30Gi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: redhat-registry-credentials | ||
| namespace: openshift-virtualization-os-images | ||
| type: Opaque | ||
| data: | ||
| accessKeyId: d21hcng= | ||
| secretKey: T3JiaXQxMjMh | ||
rbo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,5 @@ resources: | |
| #- OperatorGroup.yaml | ||
| #- Subscription.yaml | ||
| - MigrationPolicy/ | ||
| - instancetypes/ | ||
| - templates/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| kind: Template | ||
| apiVersion: template.openshift.io/v1 | ||
| metadata: | ||
| name: rhel10-broadwell | ||
| namespace: openshift | ||
| labels: | ||
| app.kubernetes.io/name: custom-templates | ||
| flavor.template.kubevirt.io/medium: 'true' | ||
| os.template.kubevirt.io/rhel10.0: 'true' | ||
| template.kubevirt.io/architecture: amd64 | ||
| template.kubevirt.io/type: vm | ||
| vm.kubevirt.io/template: rhel10-haswell | ||
| vm.kubevirt.io/template.namespace: openshift | ||
| workload.template.kubevirt.io/server: 'true' | ||
| annotations: | ||
| description: RHEL 10 Template using the existing rhel10 VolumeSnapshot DataSource. | ||
| iconClass: icon-rhel | ||
| openshift.io/display-name: Red Hat Enterprise Linux 10 (Broadwell-v4) | ||
| openshift.io/provider-display-name: '' | ||
| tags: 'kubevirt,virtualmachine,rhel,rhel10' | ||
| template.kubevirt.io/provider: '' | ||
| objects: | ||
| - apiVersion: kubevirt.io/v1 | ||
| kind: VirtualMachine | ||
| metadata: | ||
| labels: | ||
| app: '${NAME}' | ||
| vm.kubevirt.io/template: rhel10-broadwell | ||
| vm.kubevirt.io/template.namespace: openshift | ||
| name: '${NAME}' | ||
| spec: | ||
| dataVolumeTemplates: | ||
| - apiVersion: cdi.kubevirt.io/v1beta1 | ||
| kind: DataVolume | ||
| metadata: | ||
| name: '${NAME}' | ||
| spec: | ||
| sourceRef: | ||
| kind: DataSource | ||
| name: rhel10 | ||
| namespace: openshift-virtualization-os-images | ||
| storage: | ||
| resources: | ||
| requests: | ||
| storage: 30Gi | ||
| runStrategy: Halted | ||
| template: | ||
| metadata: | ||
| labels: | ||
| kubevirt.io/domain: '${NAME}' | ||
| spec: | ||
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: kubernetes.io/hostname | ||
| operator: In | ||
| values: | ||
| - storm5 | ||
| - storm6 | ||
| matchFields: [] | ||
| domain: | ||
| cpu: | ||
| cores: 1 | ||
| sockets: 1 | ||
| threads: 1 | ||
| model: Broadwell-v4 | ||
| devices: | ||
| disks: | ||
| - disk: | ||
| bus: virtio | ||
| name: rootdisk | ||
| - disk: | ||
| bus: virtio | ||
| name: cloudinitdisk | ||
| interfaces: | ||
| - masquerade: {} | ||
| model: virtio | ||
| name: default | ||
| memory: | ||
| guest: 4Gi | ||
| networks: | ||
| - name: default | ||
| pod: {} | ||
| volumes: | ||
| - dataVolume: | ||
| name: '${NAME}' | ||
| name: rootdisk | ||
| - cloudInitNoCloud: | ||
| userData: |- | ||
| #cloud-config | ||
| user: cloud-user | ||
| password: ${CLOUD_USER_PASSWORD} | ||
| name: cloudinitdisk | ||
| parameters: | ||
| - name: NAME | ||
| description: Name for the new VM | ||
| generate: expression | ||
| from: 'rhel10-[a-z0-9]{6}' | ||
| - name: CLOUD_USER_PASSWORD | ||
| description: Password for cloud-user | ||
| generate: expression | ||
| from: '[a-z0-9]{8}' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| kind: Template | ||
| apiVersion: template.openshift.io/v1 | ||
| metadata: | ||
| name: rhel10-haswell | ||
| namespace: openshift | ||
| labels: | ||
| template.kubevirt.io/architecture: amd64 | ||
| os.template.kubevirt.io/rhel10.0: 'true' | ||
| template.kubevirt.io/type: vm | ||
| vm.kubevirt.io/template: rhel10-ivy-manual | ||
| flavor.template.kubevirt.io/medium: 'true' | ||
| template.kubevirt.io/default-os-variant: 'true' | ||
| app.kubernetes.io/name: custom-templates | ||
| vm.kubevirt.io/template.namespace: openshift | ||
| workload.template.kubevirt.io/server: 'true' | ||
| annotations: | ||
| description: RHEL 10 Template using the existing rhel10 VolumeSnapshot DataSource. | ||
| iconClass: icon-rhel | ||
| openshift.io/display-name: Red Hat Enterprise Linux 10 (Haswell-v4) | ||
| openshift.io/provider-display-name: '' | ||
| tags: 'kubevirt,virtualmachine,rhel,rhel10' | ||
| template.kubevirt.io/provider: '' | ||
| objects: | ||
| - apiVersion: kubevirt.io/v1 | ||
| kind: VirtualMachine | ||
| metadata: | ||
| labels: | ||
| app: '${NAME}' | ||
| vm.kubevirt.io/template: rhel10-haswell | ||
| vm.kubevirt.io/template.namespace: openshift | ||
| name: '${NAME}' | ||
| spec: | ||
| dataVolumeTemplates: | ||
| - apiVersion: cdi.kubevirt.io/v1beta1 | ||
| kind: DataVolume | ||
| metadata: | ||
| name: '${NAME}' | ||
| spec: | ||
| sourceRef: | ||
| kind: DataSource | ||
| name: rhel10 | ||
| namespace: openshift-virtualization-os-images | ||
| storage: | ||
| resources: | ||
| requests: | ||
| storage: 30Gi | ||
| runStrategy: Halted | ||
| template: | ||
| metadata: | ||
| labels: | ||
| kubevirt.io/domain: '${NAME}' | ||
| spec: | ||
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: kubernetes.io/hostname | ||
| operator: In | ||
| values: | ||
| - storm5 | ||
| - storm6 | ||
| - storm2 | ||
| - storm3 | ||
| matchFields: [] | ||
| domain: | ||
| cpu: | ||
| cores: 1 | ||
| sockets: 1 | ||
| threads: 1 | ||
| features: | ||
| - name: vmx-rdseed-exit | ||
| policy: disable | ||
| model: Haswell-v4 | ||
| devices: | ||
| disks: | ||
| - disk: | ||
| bus: virtio | ||
| name: rootdisk | ||
| - disk: | ||
| bus: virtio | ||
| name: cloudinitdisk | ||
| interfaces: | ||
| - masquerade: {} | ||
| model: virtio | ||
| name: default | ||
| memory: | ||
| guest: 4Gi | ||
| networks: | ||
| - name: default | ||
| pod: {} | ||
| volumes: | ||
| - dataVolume: | ||
| name: '${NAME}' | ||
| name: rootdisk | ||
| - cloudInitNoCloud: | ||
| userData: | | ||
| #cloud-config | ||
| user: cloud-user | ||
| password: redhat123 | ||
| name: cloudinitdisk | ||
| parameters: | ||
| - name: NAME | ||
| description: Name for the new VM | ||
| generate: expression | ||
| from: 'rhel10-[a-z0-9]{6}' | ||
| - name: CLOUD_USER_PASSWORD | ||
| description: Password for cloud-user | ||
| generate: expression | ||
| from: '[a-z0-9]{8}' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we not use the DataSource:
It's based on
registry.redhat.io/rhel10/rhel-guest-image:latestas well?You mentioned it in the call, but I forgot it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to have a new one since we had trouble with the metadata in the Original RHEL10 in connection with the SSP Operator. Furthermore, as you remember - we discussed to push all the customize stuff also in a new NS - "custom-os-images"