Skip to content

Replacing Carousel with Grid Layout for Better Accessibility and UX #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barbaraperic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replacing Carousel with Grid Layout for Better Accessibility and UX #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 0 additions & 110 deletions components/Carousel.vue
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions components/CarouselSection.vue
View file
Open in desktop

This file was deleted.

26 changes: 26 additions & 0 deletions components/GridLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<template>
<div class="grid-layout">
<slot />
</div>
</template>

<style lang="postcss" scoped>
.grid-layout {
display: grid;
grid-template-columns: repeat(auto-fill, minmax(320px, 1fr));
gap: 1rem;
width: 100%;
}

:slotted(.card) {
display: flex;
flex-direction: column;
margin-bottom: 1rem;
}

@media (min-width: 1024px) {
.grid-layout {
gap: 1.5rem;
}
}
</style>
23 changes: 23 additions & 0 deletions components/GridSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<script lang="ts" setup>
interface GridSectionProps {
title: string
description: string
}
defineProps<GridSectionProps>()
</script>

<template>
<section class="grid-margins flex flex-col gap-8">
<div class="lg:w-1/2 md:w-2/3">
<Heading type="h2" class="font-medium">
{{ title }}
</Heading>
<p class="mt-4 text-base p1">
{{ description }}
</p>
</div>
<GridLayout>
<slot />
</GridLayout>
</section>
</template>
7 changes: 4 additions & 3 deletions components/KeyFeatures.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,15 @@ const cards = [{
</script>

<template>
<CarouselSection
<GridSection
class="key-features"
title="Key Features"
description="Check out how we’re cranking up the heat with upcoming features and innovations to make your data storage experience scorching hot!"
>
<CardCell v-for="card in cards" :key="card.title" class="card bg-brand-4 color-brand-3">
<div class="pill h-3em w-3em flex-inline items-center justify-center rounded-full bg-white">
<AppIcon :i="card.icon" />
<div v-if="card.icon.startsWith('i-')" :class="card.icon" />
<span v-else>{{ card.icon }}</span>
</div>
<div class="card-body mt-6 color-brand-3">
<Heading type="h3" class="font-medium">
Expand All @@ -70,7 +71,7 @@ const cards = [{
</p>
</div>
</CardCell>
</CarouselSection>
</GridSection>
</template>

<style lang="postcss" scoped>
Expand Down
4 changes: 2 additions & 2 deletions components/Roadmap.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const cards = [{
</script>

<template>
<CarouselSection
<GridSection
class="roadmap"
title="Our Sizzling Roadmap"
description="Check out how we’re cranking up the heat with upcoming features and innovations to make your data storage experience scorching hot!"
Expand All @@ -42,7 +42,7 @@ const cards = [{
</p>
</div>
</CardCell>
</CarouselSection>
</GridSection>
</template>

<style lang="postcss" scoped>
Expand Down