feat: Join voice channel button in ChannelHeader#992
Closed
mitchirhd wants to merge 2 commits intostoatchat:mainfrom
Closed
feat: Join voice channel button in ChannelHeader#992mitchirhd wants to merge 2 commits intostoatchat:mainfrom
mitchirhd wants to merge 2 commits intostoatchat:mainfrom
Conversation
added 2 commits
March 4, 2026 22:44
Signed-off-by: Michael Reinhard <michaelreinhard1711@gmail.com>
Signed-off-by: Michael Reinhard <michaelreinhard1711@gmail.com>
mitchirhd
force-pushed
the
voice-channel-box-covering
branch
from
4f21818 to
ed4f9c1
Compare
Contributor
Whoops lol, already included in #835 |
Contributor
|
Fixes #780 |
Contributor
|
Superseded by #1025 (formerly 835), which includes Insert's request to keep the banner in VC channels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the discussion Giant voice channel box covering text #1230 and wanted to fix it.
Before:
After:
The button does not appear if the user is in a call for the currently viewed channel
The button does not appear in text channels:
