Skip to content

feat: initial work on accessibility settings#579

Open
reeesespuffs wants to merge 15 commits into
mainfrom
feat/accessibility
Open

feat: initial work on accessibility settings#579
reeesespuffs wants to merge 15 commits into
mainfrom
feat/accessibility

Conversation

@reeesespuffs
Copy link
Copy Markdown
Member

@reeesespuffs reeesespuffs commented Dec 30, 2025 •
edited
Loading

@reeesespuffs
feat: initial work on accessibility settings
7041e7e 
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@reeesespuffs
fix: format
c2d2299 
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@reeesespuffs
Merge branch 'main' into feat/accessibility
ad8b89a
insertish
insertish previously requested changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@insertish insertish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I noticed

Comment thread packages/client/components/app/interface/settings/user/Accessibility.tsx Outdated
@reeesespuffs
fix: capital lost
6199b80 
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@reeesespuffs reeesespuffs enabled auto-merge (squash) January 28, 2026 22:57
@insertish
Copy link
Copy Markdown
Contributor

insertish commented Feb 9, 2026

ugh, why does it feel the need to add line numbers (referring to conflicts on PR)

@github-actions github-actions Bot force-pushed the feat/accessibility branch 2 times, most recently from 2ea6729 to 255a599 Compare March 10, 2026 10:01
@github-actions github-actions Bot force-pushed the feat/accessibility branch from 255a599 to 6e86642 Compare March 10, 2026 10:02
mihaicm93
mihaicm93 previously approved these changes Mar 10, 2026
View reviewed changes
@reeesespuffs reeesespuffs removed the request for review from insertish March 10, 2026 10:12
@reeesespuffs reeesespuffs dismissed insertish’s stale review March 10, 2026 10:13

requested changes were resolved

@mihaicm93 mihaicm93 dismissed their stale review March 10, 2026 12:49

Stuck checks test

@mihaicm93 mihaicm93 disabled auto-merge March 10, 2026 12:50
@mihaicm93 mihaicm93 enabled auto-merge (squash) March 10, 2026 12:51
@ThomasJRyan ThomasJRyan requested a review from infi March 12, 2026 15:07
@chrishultin chrishultin disabled auto-merge March 13, 2026 00:52
@ThomasJRyan
Copy link
Copy Markdown
Contributor

ThomasJRyan commented Mar 13, 2026

@reeesespuffs can you add in some screenshots of any UI changes you've made?

@ThomasJRyan ThomasJRyan added the ux review This needs UX review label Mar 13, 2026
reeesespuffs and others added 3 commits March 12, 2026 23:35
@reeesespuffs
fix: resolve conflicts
558b810 
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@reeesespuffs
Merge branch 'main' into feat/accessibility
e10a740 
Signed-off-by: marcy <69540471+reeesespuffs@users.noreply.github.com>
@stoat-ci
chore: generate i18n catalog
a061e98
@reeesespuffs
Copy link
Copy Markdown
Member Author

reeesespuffs commented Mar 13, 2026

@insertish the conflicts have been resolved, unfortunately some of the checks are stuck so this PR will need to be merged by you

@Pecacheu
Copy link
Copy Markdown
Contributor

Pecacheu commented Mar 13, 2026

Love the look of this, however correct me if I'm wrong but I don't see anything in the actual code that makes the send message button always appear on mobile as the tooltip claims (and that isn't the current behavior of the current release). I'd be happy to add that to #835 though, it makes a lot of sense.

@Pecacheu Pecacheu mentioned this pull request Mar 14, 2026
Open
@insertish
Copy link
Copy Markdown
Contributor

insertish commented Mar 21, 2026

Please drop i18n/catalogs from the PR, workflow has been changed, sorry for the inconvenience 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrishultin chrishultin chrishultin approved these changes

@mihaicm93 mihaicm93 mihaicm93 approved these changes

@insertish insertish insertish left review comments

@infi infi Awaiting requested review from infi

Assignees

No one assigned

Labels

ux review This needs UX review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@reeesespuffs @insertish @ThomasJRyan @Pecacheu @chrishultin @mihaicm93 @infi @stoat-ci