Conversation
Pecacheu
force-pushed
the
refactor/voicepip
branch
from
bfbbd94 to
422ba5d
Compare
…hscreens Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
- Also un-borked the VoiceCallCardPreview which it borked Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
- Add missing tooltips to VoiceCallCard buttons - Add missing translatable strings to VoiceCallCardActions Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
- Don't force showing video bar every time focus mode is enabled Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
- Fix reversed mute/unmute text Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Pecacheu
force-pushed
the
refactor/voicepip
branch
from
422ba5d to
197a11f
Compare
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Dadadah
left a comment
Dadadah
left a comment
There was a problem hiding this comment.
Please remove the TODOs and dead code regarding your other PRs. If this were to get merged but the other PRs weren't these TODOs would require a PR to be removed. These lines are unrelated to this PR.
Could you show more pictures of the pip, including without focus, with just voice users (no video), and a screencast of the pip being moved around the screen?
| ofsX = 0, | ||
| ofsY = 0; | ||
|
|
||
| function touchToMouse(e: MouseEvent | TouchEvent, down = false) { |
There was a problem hiding this comment.
Could this, instead of returning a boolean, return a partial TouchEvent with just the info needed for processing? That would get rid of the need to use ts-expect-error here. Calling it could be like const partialEvent = touchToMouse(e). It would also get rid of the e as MouseEvent in the mouseDown function below.
| ofsX = 0, | ||
| ofsY = 0; | ||
|
|
||
| function touchToMouse(e: MouseEvent | TouchEvent, down = false) { |
There was a problem hiding this comment.
Should this function be moved into a utility library somewhere to allow this across the app?
|
|
||
| sty.transition = "all .2s cubic-bezier(0, 1.67, 0.85, 0.8)"; | ||
| setFloat(left ? (top ? "tl" : "bl") : top ? "tr" : "br"); | ||
| setTimeout(() => (sty.transition = ""), 1); |
There was a problem hiding this comment.
I haven't tested this, but I think this would result in the transition being lost if you click, drop, then click within 1 second, wait 1 second and drag to a new spot.
| }, | ||
| compoundVariants: [ | ||
| { | ||
| mode: ["floating", "moving"], |
There was a problem hiding this comment.
I don't think this can be reached? Mode is a union type of "floating" and "moving", therefore it can't be both.
2 participants
main