Skip to content

fix: Add button debounce to solve click-through issue on Chrome mobile #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pecacheu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Add button debounce to solve click-through issue on Chrome mobile #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54b10f9
fix: Add button debounce to solve click-through issue on Chrome mobile
Pecacheu Apr 4, 2026
ff5bd90
fix: Apply same code to IconButton
Pecacheu Apr 4, 2026
06e18fa
fix: Add note about reactivity
Pecacheu Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/client/components/ui/components/design/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { Show, createRenderEffect, on, splitProps } from "solid-js";
import { Show, createRenderEffect, mergeProps, on, splitProps } from "solid-js";
import { JSX } from "solid-js/jsx-runtime";

import { AriaButtonProps, createButton } from "@solid-aria/button";
import { cva } from "styled-system/css/cva";

import { debounce } from "@revolt/common";
Comment thread
Pecacheu marked this conversation as resolved.

import { Ripple } from "./Ripple";
import { typography } from "./Text";

Expand Down Expand Up @@ -118,11 +120,19 @@ export function Button(props: Props) {
),
);

const { buttonProps } = createButton(rest, () => ref);
const [btn, noBtnRest] = splitProps(rest, ["onPress"]);

//Eslint being silly, this is reactive
// eslint-disable-next-line @typescript-eslint/no-explicit-any, solid/reactivity
Comment thread
Pecacheu marked this conversation as resolved.
const onPress = debounce((e: any) => btn.onPress?.(e), 100),
btnRest = mergeProps(noBtnRest, { onPress });

const { buttonProps } = createButton(btnRest, () => ref);
return (
<button
{...passthrough}
{...buttonProps}
onTouchEnd={onPress}
ref={ref}
class={button({
shape: shape(),
Expand Down
14 changes: 12 additions & 2 deletions packages/client/components/ui/components/design/IconButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { Show, splitProps } from "solid-js";
import { mergeProps, Show, splitProps } from "solid-js";
import { JSX } from "solid-js/jsx-runtime";

import { AriaButtonProps, createButton } from "@solid-aria/button";
import { cva } from "styled-system/css/cva";

import { debounce } from "@revolt/common";

import { Ripple } from "./Ripple";
import { typography } from "./Text";

Expand Down Expand Up @@ -39,11 +41,19 @@ export function IconButton(props: Props) {
]);
let ref: HTMLButtonElement | undefined;

const { buttonProps } = createButton(rest, () => ref);
const [btn, noBtnRest] = splitProps(rest, ["onPress"]);

//Eslint being silly, this is reactive
// eslint-disable-next-line @typescript-eslint/no-explicit-any, solid/reactivity
const onPress = debounce((e: any) => btn.onPress?.(e), 100),
restBtn = mergeProps(noBtnRest, { onPress });

const { buttonProps } = createButton(restBtn, () => ref);
return (
<button
{...passthrough}
{...buttonProps}
onTouchEnd={onPress}
ref={ref}
class={iconButton2({
...style,
Expand Down
Loading