fix: properly check if link is in scope of app#1037
Merged
Pecacheu merged 2 commits intostoatchat:mainfrom May 7, 2026
Merged
Conversation
Signed-off-by: Amy <[email protected]>
mihaicm93
approved these changes
Mar 17, 2026
chrishultin
approved these changes
Mar 17, 2026
Contributor
|
Not sure if a hard-coded list of endpoints like that is the ideal way to detect it, since it will have to be updated if we add any more in the future, but it'll definitely do for now to solve the issue. |
Contributor
|
Also if/when this gets merged I will integrate it into #999 because checking the scope of links is important there. Though in that PR it will require a small change of adding the URL of the current instance (if not Stoat) to the list. Currently that is not necessary because the instance can be assumed to be Stoat unless someone rebuilds the client. |
Pecacheu
added a commit
to Pecacheu/for-web
that referenced
this pull request
Mar 29, 2026
- Support cross-instance channel/server/invite links (Builds on work in stoatchat#1037) - Auto-redirect to appropriate instance as needed, logging into most recent saved account on instance - Fix regex for paramsFromPathname to support instance prefix - Fix annoying draft console logging Signed-off-by: Pecacheu <[email protected]>
Pecacheu
added a commit
to Pecacheu/for-web
that referenced
this pull request
Mar 31, 2026
- Support cross-instance channel/server/invite links (Builds on work in stoatchat#1037) - Auto-redirect to appropriate instance as needed, logging into most recent saved account on instance - Fix regex for paramsFromPathname to support instance prefix - Fix annoying draft console logging Signed-off-by: Pecacheu <[email protected]>
Pecacheu
added a commit
to Pecacheu/for-web
that referenced
this pull request
Apr 12, 2026
- Support cross-instance channel/server/invite links (Builds on work in stoatchat#1037) - Auto-redirect to appropriate instance as needed, logging into most recent saved account on instance - Fix regex for paramsFromPathname to support instance prefix - Fix annoying draft console logging Signed-off-by: Pecacheu <[email protected]>
Pecacheu
added a commit
to Pecacheu/for-web
that referenced
this pull request
Apr 24, 2026
- Support cross-instance channel/server/invite links (Builds on work in stoatchat#1037) - Auto-redirect to appropriate instance as needed, logging into most recent saved account on instance - Fix regex for paramsFromPathname to support instance prefix - Fix annoying draft console logging Signed-off-by: Pecacheu <[email protected]>
Member
|
@amycatgirl can you remove the translations from this pr? The workflow has since been fixed. |
amycatgirl
force-pushed
the
fix/links-to-stoat-domain-workaround
branch
from
d654457 to
1188acb
Compare
Contributor
Author
|
I removed the translation commit. I am now going to rebase the branch into the latest commit |
Pecacheu
added a commit
to Pecacheu/for-web
that referenced
this pull request
May 8, 2026
- Support cross-instance channel/server/invite links (Builds on work in stoatchat#1037) - Auto-redirect to appropriate instance as needed, logging into most recent saved account on instance - Fix regex for paramsFromPathname to support instance prefix - Fix annoying draft console logging Signed-off-by: Pecacheu <[email protected]>
Pecacheu
pushed a commit
to Pecacheu/for-web
that referenced
this pull request
May 8, 2026
Signed-off-by: Amy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #737 because i completely fucked up the branch lol
also takes into account the review inside of the previous PR