Skip to content

chore: properly handle bulk deletion in message view #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amycatgirl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: properly handle bulk deletion in message view #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/client/components/app/interface/channels/text/Messages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,17 +671,34 @@ export function Messages(props: Props) {
);
}
}
/**
* Handle bulk-deleted messages
*/
function onMessageDeleteBulk(
deleted_messages: { id: string; channelId: string }[],
channel?: { id: string },
) {
if (channel?.id === props.channel.id) {
setMessages((messages) =>
messages.filter(
(msg) => !deleted_messages.find((m) => m.id === msg.id),
),
);
}
}

// Add listener for messages
onMount(() => {
const c = client();
c.addListener("messageCreate", onMessage);
c.addListener("messageDelete", onMessageDelete);
c.addListener("messageDeleteBulk", onMessageDeleteBulk);
Copy link
Copy Markdown
Contributor

@chrishultin chrishultin Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something here? Does this ever get called?

Copy link
Copy Markdown
Contributor Author

@amycatgirl amycatgirl Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but only when the element is first mounted. The onMessageDeleteBulk function is only called when a bulk deletion event is received by the client. The listener is also removed when the element is unmounted.

It worked on my (very limited) testing, used Automod to bulk delete 10 messages and could confirm that the message elements did not persist.

});

onCleanup(() => {
const c = client();
c.removeListener("messageCreate", onMessage);
c.removeListener("messageDeleteBulk", onMessageDeleteBulk);
c.removeListener("messageDelete", onMessageDelete);
});

Expand Down
Loading