(Closes #3366) rm LFRicSymbolTable

[arporter]

This branch was taken from the one for #1734 and therefore needs #3358 to be merged first.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (31a7191) to head (80cb9eb).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3374      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files         390      389       -1     
  Lines       54563    54521      -42     
==========================================
- Hits        54544    54502      -42     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arporter]

ITs are underway but this is ready for a first look. One for @sergisiso, @hiker or @LonelyCat124 .

[LonelyCat124]

Hi @arporter - mostly looks good, I have a couple of questions about functionality because I'm not sure what happens if find_or_create finds a symbol already in the table with the wrong datatype (or if thats possible)? From what I can see I don't see any type checking in find_or_create.

I'm somewhat loathe to suggest it, but could we get more type hints in the functions you've modified if that feels reasonable? I'm not sure what our rules w.r.t adding those in is so feel free to ignore if you think its too much.

[arporter]

Thanks Aidan. I've done the type hinting (which was harder than I expected because of having to import classes and then fix circular dependencies). The find_or_create limitation is the subject of #1057 so I've not done that.

[LonelyCat124]

Looks good now, I've set integration going and assuming no issues arise I'll proceed to merge.

[arporter]

The LFRic IT with nvfortran failed with a signal 11 so I've launched it a second time.