Fix ArrayIndexOutOfBoundsException in processMethodAnnotations - #2553
Open
MonkeyMoon104 wants to merge 1 commit into
Open
Fix ArrayIndexOutOfBoundsException in processMethodAnnotations#2553MonkeyMoon104 wants to merge 1 commit into
MonkeyMoon104 wants to merge 1 commit into
Conversation
ChestGui and other Gui subclasses declare zero-parameter methods such as update() and copy(). processMethodAnnotations always read getParameterTypes()[0] before checking parameterCount, so constructing any ChestGui crashed with Index 0 out of bounds for length 0. Only resolve the first parameter type when parameterCount is greater than zero, matching the existing zero-arg annotation handler path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayIndexOutOfBoundsExceptioninGui.processMethodAnnotationsintroduced in 0.12.1.update()/copy()) were scanned andgetParameterTypes()[0]was accessed unconditionally.parameterCount > 0.Test plan
new ChestGui(rows, title, plugin)no longer throws