feat(ui): add xhr request header and a xhr status button#360
Open
lsjostro wants to merge 1 commit intostefanprodan:masterfrom
Open
feat(ui): add xhr request header and a xhr status button#360lsjostro wants to merge 1 commit intostefanprodan:masterfrom
lsjostro wants to merge 1 commit intostefanprodan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
X-Requested-Withheader for thexhrrequest, which is sort of standard in many JS ajax libs world. Say you have a auth proxy in front of podinfo and session expires, would be nice to notify user to reload the page to re authenticate. I have added a button which pops up only ifxhrstatus not 200, clicking that reloads the page.More info about AJAX requests and how to detect them can be found here: https://cloud.google.com/iap/docs/sessions-howto#understanding_the_response