Skip to content

[6.x] Handle stop words case insensitive #14201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Mar 10, 2026
Merged

[6.x] Handle stop words case insensitive #14201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a5c207
Normalize stop words to lowercase in Comb filtering
marcorieser Mar 9, 2026
73abdad
Add test
marcorieser Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Search/Comb/Comb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,8 +1009,12 @@ private function filterStopWords($words)
return $words;
}

$lowercasedStopWords = collect($this->stop_words)
->map(fn ($word) => Str::lower($word))
->all();

foreach ($words as $key => $word) {
if (in_array($word, $this->stop_words)) {
if (in_array(Str::lower($word), $lowercasedStopWords)) {
unset($words[$key]);
}
}
Expand Down
16 changes: 16 additions & 0 deletions tests/Search/CombTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,22 @@ public function it_filters_out_results_with_disallowed_words_where_results_are_a
$this->assertEquals(['Chicken & Sweetcorn Soup'], collect($results['data'] ?? [])->pluck('data.title')->all());
}

#[Test]
public function it_handles_stop_words_case_insensitive()
{
$comb = new Comb([
['title' => 'One two three'],
['title' => 'Three four five'],
['title' => 'Five four three'],
]);

$comb->setSettings(['stop_words' => ['Three']]);

$results = $comb->lookUp('One two three');

$this->assertEquals(['One two three'], collect($results['data'] ?? [])->pluck('data.title')->all());
}

public static function searchesProvider()
{
return [
Expand Down