Handle long log lines from scrapers and plugins - #7171
Open
Maista6969 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the logging infrastructure used by scrapers and plugins to handle log lines that exceed 64KB by replacing the bufio.Scanner with a bufio.Reader that reads their stderr in chunks. I could have raised the buffer size on the bufio.Scanner but that would just be moving the breakpoint instead of fixing the core issue.
Related Issue
Resolves #7170
Testing
I have added a small test that exercises the fix and there is no change in behavior that scrapers or plugins need to be aware of.
Checklist
AI Usage Disclosure