New: Fingerprint Submission Queue (Batching)

graphql/schema/schema.graphql

@@ -560,10 +560,8 @@ type Mutation {
   stopJob(job_id: ID!): Boolean!
   stopAllJobs: Boolean!
 
-  "Submit fingerprints to stash-box instance"
-  submitStashBoxFingerprints(
-    input: StashBoxFingerprintSubmissionInput!
-  ): Boolean!
+  "Submit fingerprints to stash-box instance. Returns the ID of the job that performs the submission."
+  submitStashBoxFingerprints(input: StashBoxFingerprintSubmissionInput!): ID!
 
   "Submit scene as draft to stash-box instance"
   submitStashBoxSceneDraft(input: StashBoxDraftSubmissionInput!): ID

graphql/stash-box/query.graphql

@@ -184,6 +184,14 @@ mutation SubmitFingerprint($input: FingerprintSubmission!) {
   submitFingerprint(input: $input)
 }
 
+mutation SubmitFingerprints($input: [FingerprintBatchSubmission!]!) {
+  submitFingerprints(input: $input) {
+    scene_id
+    hash
+    error
+  }
+}
+
 query Me {
   me {
     name

internal/api/resolver_mutation_stash_box.go

@@ -8,34 +8,23 @@ import (
 	"github.com/stashapp/stash/internal/manager"
 	"github.com/stashapp/stash/pkg/logger"
 	"github.com/stashapp/stash/pkg/models"
-	"github.com/stashapp/stash/pkg/scene"
 	"github.com/stashapp/stash/pkg/sliceutil/stringslice"
 	"github.com/stashapp/stash/pkg/stashbox"
 )
 
-func (r *mutationResolver) SubmitStashBoxFingerprints(ctx context.Context, input StashBoxFingerprintSubmissionInput) (bool, error) {
+func (r *mutationResolver) SubmitStashBoxFingerprints(ctx context.Context, input StashBoxFingerprintSubmissionInput) (string, error) {
 	b, err := resolveStashBox(input.StashBoxIndex, input.StashBoxEndpoint)
 	if err != nil {
-		return false, err
+		return "", err
 	}
 
 	ids, err := stringslice.StringSliceToIntSlice(input.SceneIds)
 	if err != nil {
-		return false, err
-	}
-
-	client := r.newStashBoxClient(*b)
-
-	var scenes []*models.Scene
-
-	if err := r.withReadTxn(ctx, func(ctx context.Context) error {
-		scenes, err = r.sceneService.FindByIDs(ctx, ids, scene.LoadStashIDs, scene.LoadFiles)
-		return err
-	}); err != nil {
-		return false, err
+		return "", err
 	}
 
-	return client.SubmitFingerprints(ctx, scenes)
+	jobID := manager.GetInstance().SubmitStashBoxFingerprints(ctx, b, ids)
+	return strconv.Itoa(jobID), nil
 }
 
 func (r *mutationResolver) StashBoxBatchPerformerTag(ctx context.Context, input manager.StashBoxBatchTagInput) (string, error) {

internal/manager/manager_tasks.go

@@ -16,6 +16,8 @@ import (
 	"github.com/stashapp/stash/pkg/job"
 	"github.com/stashapp/stash/pkg/logger"
 	"github.com/stashapp/stash/pkg/models"
+	"github.com/stashapp/stash/pkg/scene"
+	"github.com/stashapp/stash/pkg/stashbox"
 )
 
 func useAsVideo(pathname string) bool {
@@ -554,6 +556,37 @@ func (s *Manager) batchTagAllPerformers(ctx context.Context, input StashBoxBatch
 	return tasks, err
 }
 
+func (s *Manager) SubmitStashBoxFingerprints(ctx context.Context, box *models.StashBox, sceneIDs []int) int {
+	j := job.MakeJobExec(func(ctx context.Context, progress *job.Progress) error {
+		logger.Infof("Submitting fingerprints for %d scene(s) to stash-box endpoint %s", len(sceneIDs), box.Endpoint)
+
+		var scenes []*models.Scene
+		if err := s.Repository.WithReadTxn(ctx, func(ctx context.Context) error {
+			var err error
+			scenes, err = s.SceneService.FindByIDs(ctx, sceneIDs, scene.LoadStashIDs, scene.LoadFiles)
+			return err
+		}); err != nil {
+			return fmt.Errorf("failed to load scenes for fingerprint submission: %w", err)
+		}
+
+		client := stashbox.NewClient(*box, stashbox.ExcludeTagPatterns(s.Config.GetScraperExcludeTagPatterns()))
+
+		result, err := client.SubmitFingerprints(ctx, scenes, progress)
+
+		// log the summary on all paths, including when the submission aborts
+		// part-way through, so the outcome is always visible
+		if result.Failed > 0 {
+			logger.Warnf("Submitted %d fingerprint(s) to stash-box, %d failed", result.Succeeded, result.Failed)
+		} else {
+			logger.Infof("Submitted %d fingerprint(s) to stash-box", result.Succeeded)
+		}
+
+		return err
+	})
+
+	return s.JobManager.Add(ctx, "Submitting fingerprints to stash-box...", j)
+}
+
 func (s *Manager) StashBoxBatchPerformerTag(ctx context.Context, box *models.StashBox, input StashBoxBatchTagInput) int {
 	j := job.MakeJobExec(func(ctx context.Context, progress *job.Progress) error {
 		logger.Infof("Initiating stash-box batch performer tag")