Repository navigation
refactor(multiverifier): move shared test fixtures to test_utils - #626
Conversation
PR SummaryLow Risk Overview Moved and re-exported: Reviewed by Cursor Bugbot for commit b5b23a0. Bugbot is set up for automated code reviews on this repo. Configure here. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c12776c to
02cb7e8
Compare
leo-starkware
left a comment
There was a problem hiding this comment.
@leo-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware).
crates/circuit_multiverifier/src/test_utils.rs line 47 at r2 (raw file):
[2299450592, 1514947052, 87572453, 633358207, 462231094, 464091325, 2016711704, 1173534648]; /// The preprocessed root of the (current) privacy Cairo verifier circuit.
remove here and below
Code quote:
(current)Move the config constants, target padding sizes, preprocessed roots, proof fixture path, and helpers shared by the multiverifier test modules out of verify_test.rs into test_utils.rs (PCS_CONFIG, LOG_BLOWUP_FACTOR, TARGET_PADDING_SIZES, CIRCUIT_N_PREPROCESSED_COLUMNS, PRIVACY_CAIRO_VERIFIER_OUTPUT_VALUES, PRIVACY_CAIRO_VERIFIER_PREPROCESSED_ROOT, MULTIVERIFIER_PREPROCESSED_ROOT, MULTIVERIFIER_OF_TWO_CAIRO_PROOFS_PATH, blake2s_u32s_host, multiverifier_preprocessed_column_log_sizes), so they can be reused by additional test modules without one test file depending on another. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
02cb7e8 to
b5b23a0
Compare
leo-starkware
left a comment
There was a problem hiding this comment.
@leo-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ilyalesokhin-starkware).
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on leo-starkware).
crates/circuit_multiverifier/src/test_utils.rs line 47 at r2 (raw file):
Previously, leo-starkware wrote…
remove here and below
Done.

Move the config constants, target padding sizes, preprocessed roots, proof
fixture path, and helpers shared by the multiverifier test modules out of
verify_test.rs into test_utils.rs (PCS_CONFIG, LOG_BLOWUP_FACTOR,
TARGET_PADDING_SIZES, CIRCUIT_N_PREPROCESSED_COLUMNS,
PRIVACY_CAIRO_VERIFIER_OUTPUT_VALUES, PRIVACY_CAIRO_VERIFIER_PREPROCESSED_ROOT,
MULTIVERIFIER_PREPROCESSED_ROOT, MULTIVERIFIER_OF_TWO_CAIRO_PROOFS_PATH,
blake2s_u32s_host, multiverifier_preprocessed_column_log_sizes), so they can be
reused by additional test modules without one test file depending on another.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com