Skip to content

refactor(multiverifier): move shared test fixtures to test_utils - #626

Merged
ilyalesokhin-starkware merged 1 commit into
mainfrom
ilya/move-multiverifier-test-fixtures
Jul 9, 2026
Merged

ilyalesokhin-starkware merged 1 commit into
mainfrom
ilya/move-multiverifier-test-fixtures

Conversation

@ilyalesokhin-starkware

Copy link
Copy Markdown
Contributor

Move the config constants, target padding sizes, preprocessed roots, proof
fixture path, and helpers shared by the multiverifier test modules out of
verify_test.rs into test_utils.rs (PCS_CONFIG, LOG_BLOWUP_FACTOR,
TARGET_PADDING_SIZES, CIRCUIT_N_PREPROCESSED_COLUMNS,
PRIVACY_CAIRO_VERIFIER_OUTPUT_VALUES, PRIVACY_CAIRO_VERIFIER_PREPROCESSED_ROOT,
MULTIVERIFIER_PREPROCESSED_ROOT, MULTIVERIFIER_OF_TWO_CAIRO_PROOFS_PATH,
blake2s_u32s_host, multiverifier_preprocessed_column_log_sizes), so they can be
reused by additional test modules without one test file depending on another.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

@cursor

cursor Bot commented Jul 7, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor with no production or verification logic changes.

Overview
Shared multiverifier test setup is consolidated in test_utils.rs so additional test modules (e.g. backward_compatibility_test) can reuse it without importing from verify_test.rs.

Moved and re-exported: PCS_CONFIG, LOG_BLOWUP_FACTOR, TARGET_PADDING_SIZES, preprocessed-root and output digests, MULTIVERIFIER_OF_TWO_CAIRO_PROOFS_PATH, blake2s_u32s_host, and multiverifier_preprocessed_column_log_sizes, with short module comments on the fixtures. verify_test.rs now imports these symbols and drops the duplicated definitions and related imports (blake2, get_pcs_config, OrderedHashMap, etc.). Test-only paths that stay local to verify tests (e.g. PRIVACY_CAIRO_VERIFIER_PROOF_PATH, CAIRO1_PROOF_PATH) remain in verify_test.rs.

Reviewed by Cursor Bugbot for commit b5b23a0. Bugbot is set up for automated code reviews on this repo. Configure here.

ilyalesokhin-starkware commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor Author

@reviewable-StarkWare

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@leo-starkware leo-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leo-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware).


crates/circuit_multiverifier/src/test_utils.rs line 47 at r2 (raw file):

    [2299450592, 1514947052, 87572453, 633358207, 462231094, 464091325, 2016711704, 1173534648];

/// The preprocessed root of the (current) privacy Cairo verifier circuit.

remove here and below

Code quote:

(current)

Move the config constants, target padding sizes, preprocessed roots, proof
fixture path, and helpers shared by the multiverifier test modules out of
verify_test.rs into test_utils.rs (PCS_CONFIG, LOG_BLOWUP_FACTOR,
TARGET_PADDING_SIZES, CIRCUIT_N_PREPROCESSED_COLUMNS,
PRIVACY_CAIRO_VERIFIER_OUTPUT_VALUES, PRIVACY_CAIRO_VERIFIER_PREPROCESSED_ROOT,
MULTIVERIFIER_PREPROCESSED_ROOT, MULTIVERIFIER_OF_TWO_CAIRO_PROOFS_PATH,
blake2s_u32s_host, multiverifier_preprocessed_column_log_sizes), so they can be
reused by additional test modules without one test file depending on another.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ilyalesokhin-starkware
ilyalesokhin-starkware force-pushed the ilya/move-multiverifier-test-fixtures branch from 02cb7e8 to b5b23a0 Compare July 9, 2026 10:31

@leo-starkware leo-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@leo-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ilyalesokhin-starkware).

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyalesokhin-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on leo-starkware).


crates/circuit_multiverifier/src/test_utils.rs line 47 at r2 (raw file):

Previously, leo-starkware wrote…

remove here and below

Done.

@ilyalesokhin-starkware
ilyalesokhin-starkware merged commit 8b51e9f into main Jul 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants