Repository navigation
wallet-api: rename STRK20 sub-accounts to shadow accounts - #406
Merged
Merged
Conversation
Renames the STRK20 sub-account concept to "shadow account" throughout the wallet API spec. Terminology only - no semantic or structural change. Breaking (wire-visible): - method wallet_strk20SubaccountCommitment -> wallet_strk20ShadowAccountCommitment - schema STRK20_SUBACCOUNT_INVOKE_ACTION -> STRK20_SHADOW_ACCOUNT_INVOKE_ACTION - action discriminator "subaccount_invoke" -> "shadow_account_invoke" The remaining changes are summaries, descriptions and titles. Prose uses "shadow account" unhyphenated, since "shadow" is an adjective rather than a prefix like "sub-". Sub-accounts were introduced after v0.10.3 and exist only in the unreleased v0.10.4-rc.0, so no deprecation alias is needed. Version left untouched here; bumps are made in separate repo-wide PRs. Note: this also renames the "sub-account anonymizer" to "shadow account anonymizer" in two descriptions. That names an on-chain contract defined outside this repo and needs confirmation from its owner. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
7 tasks
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the STRK20 sub-account concept to shadow account across the wallet API spec. Terminology only — no semantic or structural change.
Breaking (wire-visible)
wallet_strk20SubaccountCommitmentwallet_strk20ShadowAccountCommitmentSTRK20_SUBACCOUNT_INVOKE_ACTIONSTRK20_SHADOW_ACCOUNT_INVOKE_ACTION"subaccount_invoke"(action discriminator)"shadow_account_invoke"The remaining 16 changed lines are summaries, descriptions and titles.
Checklist:
npm run validate_allnpm run format🤖 Generated with Claude Code