Repository navigation
Conversation
The mobile core and the extension must pin the same Krusty release (tests/conformance/mobile-generated.test.ts), so both move from 0.11.0 to 0.14.0 together: the krusty-kms crates in mobile/core and @starknetfoundation/krusty-kms-wasm in the extension, with the adapter gate's runtime digests and the provenance test updated to the new tarball. 0.12 adds the account-class registry, Braavos v1.0.0/v1.1.0/v1.2.0 and Argent v0.5.0 classes, and reduces calculate_contract_address modulo 2^251 - 256 as the sequencer does. 0.13 drops rand for getrandom::fill and moves to starknet-rust 0.20. 0.14 pins the V3 tip on signed transactions and clears RUSTSEC-2026-0381..0387 in the lockfile. None of these change an API the core or the adapter calls. bip39 follows Krusty to 3.0.0 so the core carries one copy of the word list instead of two.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Mobile and the extension both pinned Krusty 0.11.0; latest is 0.14.0. The two must pin the same release (
tests/conformance/mobile-generated.test.tscompares the Cargo pin to the npm pin), so both move together.What
mobile/core/Cargo.toml+Cargo.lock:krusty-kms,krusty-kms-common=0.14.0;bip39=3.0.0(Krusty's copy, so one word list instead of two). Transitives: starknet-rust 0.19.1 → 0.20.x, crypto-bigint 0.7.10, ctutils 0.4.7;randandhmacdrop out.package.json/bun.lock/scripts/config-standards-policy.ts:@starknetfoundation/krusty-kms-wasm0.14.0.scripts/check-krusty-adapter.ts: new runtime digests forkrusty_kms_wasm.js/_bg.wasm; version strings in the provenance test,lib.rskrusty_version, SCOPE.md and the mobile workflow briefing.Krusty 0.11 → 0.14 (from the upstream changelog)
getAccountClassRegistry,inspectAccountDeployment,deriveArgentAccountAddressWithGuardian), Braavos v1.0.0 base + v1.1.0/v1.2.0 impl classes, Argent v0.5.0;calculate_contract_addressreduced mod2^251 - 256;getAccountClassHashes()adds Braavos/Argent keys and drops the duplicateargent_legacy0.2.0key. Neither the core nor the adapter reads those keys by name.rand→getrandom::fill; starknet-rust 0.20; WASMrandomFeltthrows instead of panicking.tippinned on client/gateway-signed txs (not used here; the core and extension hash and sign their own invokes); RUSTSEC-2026-0381..0387 cleared in the lockfile.No API the core (
sign_stark_hash,derive_*,calculate_contract_address, nostr wrap/open,ChainId) or the WASM adapter calls changed shape.Verification
cargo check --testsandcargo test --no-fail-fastinmobile/core: 289 pass, 6 fail. All 6 (accounts_parity::discovery_rows_are_worded_like_the_extension, 4×history_parity,privacy_parity::every_judged_reply_reaches_the_extension_outcome) fail identically onfeature/mobile-walletwithout this change.bun run check:krusty(known-answer + Nostr round-trip through the real 0.14.0 adapter): pass.bun run test: 3299 pass, 0 fail.check:types,check:lint,check:copy,check:imports,check:cycles,check:deadcode,check:extension: pass.check:files(a 559-line parity fixture over the 500 limit) and one@bramble/terminalswap-route smoke test incheck:workspaces.check:argent/check:privacynot run locally (no vendored outputs in this worktree).Note:
mainstays on 0.11.0 until this lands via #450 or is cherry-picked separately.