Repository navigation
Home: explain what token-list changes mean versus the wallet change #486
Description
Problem
The home screen shows two kinds of change figure, and users can't tell how they relate:
- Hero:
x% · 24h(home-view.ts). This comes fromportfolioDeltainshared/fiat.ts: the 24h price change of current holdings, weighted by value. It rebuilds each holding's value from 24h ago using today's balance, so sends, receives and swaps don't count. - Token rows:
↑ x%(changeBadgeintoken-row.ts). This is each token's own 24h price change, with no window label.
So the token percentages don't add up to the hero figure (it's a value-weighted average). And neither figure reflects changes in the user's balance, which is probably what "increase/decrease" sounds like it means.
Proposed solution
- Label both as price moves with their window, e.g. hero "Portfolio price · 24h" and rows "24h price".
- Add a short info line or tooltip: "Price change over 24h at your current balances; sends and receives aren't included."
- Out of scope unless asked for: a real change in balance-based value (needs balance history).
Additional context
Checked against #450 (feature/mobile-wallet). The logic is the same on main.
Activity
mossbot55 commentedon Oct 3, 2026
Picking this up. I will add a short explanation of what the home change figures mean (24h price move at current balances, sends and receives excluded) and confirm the wording against the copy style before opening a PR.
mossbot55 commentedon Oct 3, 2026
Implemented and opened PR #525: #525
The home hero now carries one muted caption, "Price change over 24h at your current balances; sends and receives aren't included.", rendered only when a priced baseline exists. The token rows are left as they are, so the subject is named once per screen rather than repeated on every row; the caption's plural "figures" covers them.
Checks:
bun run checkexit 0 (root 2435 pass, 0 fail; every workspace suite 0 fail); new focused tests for the caption and for its absence without a priced baseline; UI Lab desktop 1280x720 and phone 390x844 passes on the portfolio ready and prices-offline stories.One limitation worth naming: no automated accessibility scan of the wallet document is available from the UI Lab bench, so that check could not run here. It is recorded in the PR and tracked as #524.
derek-flossman commentedon Oct 13, 2026
Fixed in #525, merged into
release/v0.10.6through batch #642 (fecb613).