Send: show the estimated fee on the new-transaction page, shielded sends included #477

Activity

1. Ryun1

   added

   enhancementNew feature or requestNew feature or request

   on Oct 1, 2026
2. mossbot55 commented on Oct 3, 2026

   

   mossbot55

   on Oct 3, 2026

   Contributor

   More actions

   Acknowledged. I will show the cost of a send on the new-transaction screen, before the user commits:

   • A public send shows an estimated network fee once the recipient and amount are valid, refreshed when either changes. It is the same estimate and the same formatter the review screen uses, so the two cannot disagree.
   • A private route (shield, private send, unshield) also shows the Privacy Pool fee as its own line, attributed to the balance it is charged from, worded exactly as the review screen words it.

   The estimate is presentation only: it never blocks the flow, and the review remains the figure the send is authorized against.
3. mossbot55 commented on Oct 3, 2026

   

   mossbot55

   on Oct 3, 2026

   Contributor

   More actions

   Implemented in #521.

   The amount step now quotes the composed fee before it is committed:

   • A plain public transfer shows the network estimate, taken from the review's own estimator and rendered through a helper the review also uses, so the amount screen and the review cannot word or format the same charge two ways. When the account must deploy first, the line is the deployment-inclusive total.
   • A pool route (shield, private send, unshield) states the pool's per-batch charge, in the same sentence the review's Cost box uses and attributed to the balance it leaves. It does not invent a network fee: a deposit's gas needs a proof that does not exist yet, so the preview shows only what is knowable.

   The estimate is debounced by 400 ms and token-guarded, so a slow estimate for a superseded amount can never paint, and it carries the same read-only review request the review screen already used.

   Checks: bun run check exit 0 (wallet-ui 1545 pass 0 fail, every workspace and every gate clean); bun run --filter @bramble/ui-lab check exit 0 (224 tests). On the pre-change tree a probe typed an amount and found no fee element at all; on this branch the same probe reads the fee.

   Browser: UI Lab Storybook, desktop 1280x720 and phone 390x844 DPR3 on both surfaces. A plain send renders Estimated fee: 0.0024 STRK, a shield renders Pool fee: 6 STRK from your public balance with no network line, right-aligned under the value, no clipping or horizontal overflow on either surface or skin.

   Two things worth flagging for review:

   1. One existing guard changed meaning. sidepanel-transfer-recipient-enter.test.ts (audit chore(deps-dev): bump jsdom from 25.0.1 to 30.0.1 #248) asserted the amount step produced no wallet request. It now asserts what the request the preview makes must carry: the address on screen, never the previously chosen one.
   2. No UI Lab checkpoint showed the amount screen with an amount entered, so the affected state could not be rendered or guarded. This adds two fixture-only checkpoints and their story assertions, disclosed in the PR. The lab's send binding gains a privacy fixture so a shield route can clear; public routes ignore it, so existing checkpoints are unchanged.

   Limitations: axe cannot run against the lab's sandboxed srcdoc application document, so that scan is a best effort; the commits are not GPG-signed (this host has no signing key).
4. claude

   added

   phase:2Phase 2 — MVP single-sig walletPhase 2 — MVP single-sig wallet

   status:in-progressWork in progressWork in progress

   on Oct 5, 2026
5. derek-flossman commented on Oct 13, 2026

   

   derek-flossman

   on Oct 13, 2026

   Collaborator

   More actions

   Fixed in #521, merged into release/v0.10.6 through batch #642 (fecb613).
6. derek-flossman

   closed this as completedon Oct 13, 2026