You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Deploy account screen: cramped spacing and duplicated fee text #432
Checked the Deploy account screen on the current release line (release/v0.10.5, b8c87b13). Both symptoms in the screenshot are gone: the screen was rebuilt in #475 (rebased #466, merged 2026-10-01) with the follow-up in #489.
Duplicated fee text. The earlier binder wrote the fee three times: into the review box, into the button label (Confirm deployment · <fee>), and into the status line under the button. The current binder (bindDeploy in shell-bindings.ts) writes it once, into the Cost box between the receipt and the action, and the button label is a plain Deploy. A successful quote clears the status line. packages/presentation/wallet-ui/tests/sidepanel/shell/deploy-cost-label.test.ts asserts exactly that, and it passes on the target.
Cramped layout. The screen no longer stacks the What will happen, Risk and recovery and Maximum cost and constraints sections. It renders the account receipt, the single Cost box and the action, on the standard 12px section rhythm.
I rendered the deploy-account checkpoint in the UI Lab on the target: one fee line, 12px between the receipt and the Cost box and 12px between the Cost box and the Deploy button, with no overlap or clipping.
No code change is needed for this. Leaving it open until v0.10.5 ships; if the crowding is still visible after the release, a fresh screenshot would help me take another look.
Activity
mossbot55 commentedon Oct 3, 2026
Checked the Deploy account screen on the current release line (
release/v0.10.5,b8c87b13). Both symptoms in the screenshot are gone: the screen was rebuilt in #475 (rebased #466, merged 2026-10-01) with the follow-up in #489.Duplicated fee text. The earlier binder wrote the fee three times: into the review box, into the button label (
Confirm deployment · <fee>), and into the status line under the button. The current binder (bindDeployinshell-bindings.ts) writes it once, into theCostbox between the receipt and the action, and the button label is a plainDeploy. A successful quote clears the status line.packages/presentation/wallet-ui/tests/sidepanel/shell/deploy-cost-label.test.tsasserts exactly that, and it passes on the target.Cramped layout. The screen no longer stacks the
What will happen,Risk and recoveryandMaximum cost and constraintssections. It renders the account receipt, the singleCostbox and the action, on the standard 12px section rhythm.I rendered the deploy-account checkpoint in the UI Lab on the target: one fee line, 12px between the receipt and the Cost box and 12px between the Cost box and the Deploy button, with no overlap or clipping.
No code change is needed for this. Leaving it open until v0.10.5 ships; if the crowding is still visible after the release, a fresh screenshot would help me take another look.
Time: 5m 38s. Approx. API cost: $0.15.
derek-flossman commentedon Oct 12, 2026
Fixed on release/v0.10.6 by #636 (merge commit 7eb9028).