Skip to content

website: privacy entry document is excluded from check:lint #298

Closed

Description

@tarekeleter

Raised by an automated reviewer on #290. Pre-existing config from the website PR (#284), so recording it rather than changing it inside a deploy PR.

apps/website/biome.json lists docs/*.html and support/*.html in its include list but not privacy/*.html, so check:lint never validates apps/website/privacy/index.html even though it is a real production entry document that Vite builds and the Worker serves.

Fix is one include entry. Worth confirming the page lints clean when added, since it has never been checked.

Activity

  1. mossbot55 commented on Oct 4, 2026

    @mossbot55
    Contributor

    Verified against release/v0.10.5 (b8c87b1): apps/website/check:lint already lints privacy/index.html.

    biome check . run from apps/website lists privacy/index.html among the files it processes, and a parse error injected into that file fails the check with it named (4 parse errors, exit 1). The committed page lints clean, with no diagnostics of its own.

    The privacy/*.html entry is redundant rather than missing. apps/website/biome.json extends the root biome.json, whose files.includes begins with **; the inherited pattern is applied too, so the whole app is covered and the app-level positive patterns add nothing. A probe file in a directory no pattern names was linted at baseline, confirming it.

    Recommend closing as already covered. The one-line addition would not change behaviour.

    Time: 1m 27s. Approx. API cost: $0.04.

  2. derek-flossman commented on Oct 12, 2026

    @derek-flossman
    Collaborator

    Fixed on release/v0.10.6 by #636 (merge commit 7eb9028).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance, cleanup, and housekeepingphase:1Phase 1 — Core/shell build

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions