Support Argo Rollouts with workloadRef for restart strategy#1118
Open
a1exx-k wants to merge 2 commits intostakater:masterfrom
Open
Support Argo Rollouts with workloadRef for restart strategy#1118a1exx-k wants to merge 2 commits intostakater:masterfrom
a1exx-k wants to merge 2 commits intostakater:masterfrom
Conversation
Rollouts using spec.workloadRef instead of an inline spec.template had empty pod templates, causing Reloader to skip them silently because container scanning found no ConfigMap/Secret references to watch. This change hydrates the Rollout's template from the referenced Deployment at scan time, enabling Reloader to discover resource references and patch spec.restartAt when changes are detected. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Hydration runs on every polling cycle (~30s), making Info-level logs too noisy in production. Debug level is appropriate for routine per-cycle operations. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Author
|
@Felix-Stakater this is an attempt to address challenges mentioned in #989 and #751 (comment) Could you please review / provide your opinion on this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollouts using spec.workloadRef instead of an inline spec.template had empty pod templates, causing Reloader to skip them silently because container scanning found no ConfigMap/Secret references to watch.
This change hydrates the Rollout's template from the referenced Deployment at scan time, enabling Reloader to discover resource references and patch spec.restartAt when changes are detected.
resolves #1090