chore(operator/scaling)!: Rework Scaler state to complex enum#1195
Open
chore(operator/scaling)!: Rework Scaler state to complex enum#1195
Conversation
sbernauer
changed the title
Techassi
changed the title
Techassi
reviewed
Apr 9, 2026
| #[derive(Clone, Debug, Deserialize, Serialize, JsonSchema)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize, JsonSchema)] | ||
| #[serde(rename_all = "PascalCase")] |
Member
There was a problem hiding this comment.
I think those should be camelCase again, because the individual variants are now also camelCase again.
Suggested change
| #[serde(rename_all = "PascalCase")] | |
| #[serde(rename_all = "camelCase")] |
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Member
There was a problem hiding this comment.
question: Do we really need these tests, as we already generate the CRD preview - and any unintended change will lead to a schema change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #1190, where switch
Scaler.statusswitch to a complex enum, so that we get a little more type safety.Definition of Done Checklist
Author
Reviewer
Acceptance