-
-
Notifications
You must be signed in to change notification settings - Fork 6
fix(superset): Patch pinned packages and re-generate lock file #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
12b837c
fix(superset): Add patch to pin @types/offscreencanvas to 2019.7.0
Techassi 74eb968
refactor(superset): Use nvm to manage node and npm
Techassi 122c8c8
chore: Add scrupt to upload new nvm version to repo
Techassi fff8193
fix(superset): Add patch with re-generated package-lock.json file
Techassi c13c37e
chore(superset): Use dot to source
Techassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| VERSION=${1:?"Missing version number argument (arg 1)"} | ||
| NEXUS_USER=${2:?"Missing Nexus username argument (arg 2)"} | ||
|
|
||
| read -r -s -p "Nexus Password: " NEXUS_PASSWORD | ||
| echo "" | ||
|
|
||
| # https://stackoverflow.com/questions/4632028/how-to-create-a-temporary-directory | ||
| # Find the directory name of the script | ||
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | ||
|
|
||
| # the temp directory used, within $DIR | ||
| WORK_DIR=$(mktemp -d -p "$DIR") | ||
|
|
||
| # check if tmp dir was created | ||
| if [[ ! "$WORK_DIR" || ! -d "$WORK_DIR" ]]; then | ||
| echo "Could not create temp dir" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # deletes the temp directory | ||
| function cleanup { | ||
| rm -rf "$WORK_DIR" | ||
| } | ||
|
|
||
| # register the cleanup function to be called on the EXIT signal | ||
| trap cleanup EXIT | ||
|
|
||
| cd "$WORK_DIR" || exit | ||
|
|
||
| echo "Downloading nvm.sh @ $VERSION from github.com" | ||
| curl --fail -L --progress-bar -o "nvm-$VERSION.sh" "https://raw.githubusercontent.com/nvm-sh/nvm/refs/tags/${VERSION}/nvm.sh" | ||
|
|
||
| echo "Uploading nvm-$VERSION.sh to Nexus" | ||
| curl --fail -o /dev/null --progress-bar -u "$NEXUS_USER:$NEXUS_PASSWORD" \ | ||
| --upload-file "nvm-$VERSION.sh" \ | ||
| 'https://repo.stackable.tech/repository/packages/nvm/' | ||
|
|
||
| echo "Successfully uploaded new version $VERSION to Nexus" | ||
| echo "https://repo.stackable.tech/service/rest/repository/browse/packages/nvm/" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
superset/stackable/patches/4.1.4/0003-Pin-types-offscreencanvas-to-2019.7.0.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| From de686d44116e76753c45efea2faed4e187032c4f Mon Sep 17 00:00:00 2001 | ||
| From: Techassi <git@techassi.dev> | ||
| Date: Tue, 7 Apr 2026 08:56:30 +0200 | ||
| Subject: Pin @types/offscreencanvas to 2019.7.0 | ||
|
|
||
| This is again a similar issue like #1363. | ||
| --- | ||
| superset-frontend/package.json | 1 + | ||
| 1 file changed, 1 insertion(+) | ||
|
|
||
| diff --git a/superset-frontend/package.json b/superset-frontend/package.json | ||
| index 0f59fff60..bc2746107 100644 | ||
| --- a/superset-frontend/package.json | ||
| +++ b/superset-frontend/package.json | ||
| @@ -365,6 +365,7 @@ | ||
| "ansi-regex": "^4.1.1" | ||
| }, | ||
| "puppeteer": "^22.4.1", | ||
| + "@types/offscreencanvas": "2019.7.0", | ||
| "@types/react": "^16.9.53", | ||
| "sax": "1.2.4" | ||
| }, |
130 changes: 130 additions & 0 deletions
130
superset/stackable/patches/4.1.4/0004-Re-generate-package-lock.json-file.patch
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.