Feature/task sim 002 add pet age validation#2364
Open
BenjaminWong1205 wants to merge 2 commits intospring-projects:mainfrom
Open
Feature/task sim 002 add pet age validation#2364BenjaminWong1205 wants to merge 2 commits intospring-projects:mainfrom
BenjaminWong1205 wants to merge 2 commits intospring-projects:mainfrom
Conversation
- Add PetValidator logic for birth date (past & <20 years) - Remove duplicate validation from PetController - Add 5 boundary test cases - Coverage: 94% (PetValidator 100%) - All tests passed Closes TASK-SIM-002
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TASK-SIM-002] feat: add pet age validation
Summary
Added validation to ensure pet birth dates are in the past and pets are not older than 20 years.
Changes
PetValidatorwith date range checks (Past & <20 years)PetControllerTest Results
PetValidatorcoverage: 100%Testing Scenarios
Checklist