Skip to content

Pet controller update #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WJunn987 wants to merge 12 commits into
base: main
Choose a base branch
from
+32 −8
Open

Pet controller update #2359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b774500
Updated vet repository implementation
Apr 18, 2026
d8c55de
Merge pull request #1 from BigRen0606/feature/request-validation
BigRen0606 Apr 18, 2026
94fc35a
Update UI Text labels in vet list page
Apr 18, 2026
2c83887
Merge pull request #3 from ky7721/feature/ui-text-update
ky7721 Apr 18, 2026
a0fa874
Update Owner List UI
Apr 18, 2026
b38e86a
Update the Successfull messages for PetController
WJunn987 Apr 18, 2026
b8af30f
Merge pull request #4 from ky7721/feature/owner-list-update
BigRen0606 Apr 18, 2026
2ce65df
Merge pull request #5 from ky7721/WJChanges
WJunn987 Apr 18, 2026
6ae9627
Add CI pipeline using Github Actions
Apr 18, 2026
efd7941
Update Pet Controller Add Successfull Msg
WJunn987 Apr 18, 2026
6fbd3da
Fix VetRepository class definition
Apr 18, 2026
967aae1
Merge branch 'main' into PetControllerUpdate
WJunn987 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Java CI

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Set up Java
uses: actions/setup-java@v3
with:
java-version: '17'
distribution: 'temurin'

- name: Build with Maven
run: mvn clean install
4 changes: 2 additions & 2 deletions src/main/java/org/springframework/samples/petclinic/owner/PetController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public String processCreationForm(Owner owner, @Valid Pet pet, BindingResult res

owner.addPet(pet);
this.owners.save(owner);
redirectAttributes.addFlashAttribute("message", "New Pet has been Added");
redirectAttributes.addFlashAttribute("message", "Pet successfully added!");
return "redirect:/owners/{ownerId}";
Comment on lines +124 to 125
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title suggests only a PetController change, but this PR also includes vet UI template updates and a major rewrite of VetRepository.java (introducing a controller). Please align the PR title/description with the actual scope, or split the unrelated changes into separate PRs for reviewability.

Copilot uses AI. Check for mistakes.
}

Expand Down Expand Up @@ -154,7 +154,7 @@ public String processUpdateForm(Owner owner, @Valid Pet pet, BindingResult resul
}

updatePetDetails(owner, pet);
redirectAttributes.addFlashAttribute("message", "Pet details has been edited");
redirectAttributes.addFlashAttribute("message", "Pet updated successfully!");
return "redirect:/owners/{ownerId}";
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/resources/templates/owners/ownersList.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

<body>

<h2 th:text="#{owners}">Owners</h2>
<h2 th:text="#{owners}">Pet Owners Directory</h2>

<table id="owners" class="table table-striped">
<thead>
<tr>
<th th:text="#{name}" style="width: 150px;">Name</th>
<th th:text="#{address}" style="width: 200px;">Address</th>
<th th:text="#{name}" style="width: 150px;">Owner Name</th>
<th th:text="#{address}" style="width: 200px;">Home Address</th>
<th th:text="#{city}">City</th>
<th th:text="#{telephone}" style="width: 120px">Telephone</th>
<th th:text="#{pets}">Pets</th>
Expand Down
6 changes: 3 additions & 3 deletions src/main/resources/templates/vets/vetList.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

<body>

<h2 th:text="#{vets}">Veterinarians</h2>
<h2 th:text="#{vets}">Veterinarian Directory</h2>

<table id="vets" class="table table-striped">
<thead>
<tr>
<th th:text="#{name}">Name</th>
<th th:text="#{specialties}">Specialties</th>
<th th:text="#{name}">Veterinarian Name</th>
<th th:text="#{specialties}">Areas of Expertise</th>
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback text changes (e.g., “Veterinarian Directory”, “Veterinarian Name”) won’t be shown at runtime because th:text replaces the element content with the value from the message bundle keys (vets, name, specialties). If the intent is to change the UI labels, update the corresponding entries in src/main/resources/messages/messages*.properties or introduce new message keys.

Suggested change
<th th:text="#{specialties}">Areas of Expertise</th>
<th th:text="#{specialties}">Specialties</th>

Copilot uses AI. Check for mistakes.
</tr>
</thead>
<tbody>
Expand Down