chore: Improve locale affinity logic with LanguageUtils#19
Merged
ericfjosne merged 1 commit intomainfrom Jun 11, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can improve and optimize the locale affinity logic by making use of the newly introduced
LanguageUtilsclass.Instead of relying on a score-based affinity only, we first calculate a "same language" affinity by testing for corresponding spoken language.
This actually has improved the results for several locales:
SAME_OR_INTERCHANGEABLE. The score based implementation enforces script matching, which was not a good fit for the affinity logic. For instance:hr(Croatian) andbs(Bosnian) are now matched with each other with an affinitySAME_OR_INTERCHANGEABLE, whether Bosnian is written in Latin or Cyrillic script, which is a more accurate outcome.nn(Norwegian Nynorsk) is now matched withnb(Norwegian Bokmål) with an affinitySAME_OR_INTERCHANGEABLEinstead ofLOWwhich is a more accurate outcome.It is also a nice logic optimization, as we won't systematically be calculating maximized locales (which is a costly operation).