added triplet interactions: ring-exchange and spin-chirality coupling#462
Open
SpiritSuperUser wants to merge 3 commits into
Open
added triplet interactions: ring-exchange and spin-chirality coupling#462SpiritSuperUser wants to merge 3 commits into
SpiritSuperUser wants to merge 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #462 +/- ##
===========================================
- Coverage 48.04% 47.31% -0.73%
===========================================
Files 72 72
Lines 11242 11450 +208
===========================================
+ Hits 5401 5418 +17
- Misses 5841 6032 +191 |
GPMueller
requested changes
Nov 5, 2018
Member
GPMueller
left a comment
GPMueller
left a comment
There was a problem hiding this comment.
The CUDA version of the Heisenberg Hamiltonian is missing the corresponding changes.
A unit test would be good, just to make sure the code at least does not crash.
Also, indentation should be checked to be spaces.
GPMueller
force-pushed
the
develop
branch
3 times, most recently
from
0a4cc38 to
c5dda64
Compare
GPMueller
force-pushed
the
develop
branch
2 times, most recently
from
d06f4af to
218b5f5
Compare
GPMueller
force-pushed
the
develop
branch
3 times, most recently
from
a056662 to
02dbca6
Compare
GPMueller
force-pushed
the
develop
branch
2 times, most recently
from
5a61c3e to
e2ac088
Compare
GPMueller
force-pushed
the
develop
branch
3 times, most recently
from
0ad5b3c to
6d1996b
Compare
GPMueller
force-pushed
the
develop
branch
8 times, most recently
from
d8f00a2 to
9532235
Compare
Member
|
I updated this PR to the current Note, unit tests should still be implemented in order to avoid accidentally breaking it and providing a broken feature. |
GPMueller
force-pushed
the
develop
branch
2 times, most recently
from
212372f to
f49c114
Compare
muellan
force-pushed
the
develop
branch
9 times, most recently
from
63fbd74 to
2edff73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.