fix(rhino-importer): Fix rhino retrying already failed jobs #1367
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1367 +/- ##
==========================================
+ Coverage 32.17% 32.27% +0.10%
==========================================
Files 114 114
Lines 3267 3250 -17
Branches 349 349
==========================================
- Hits 1051 1049 -2
+ Misses 2177 2162 -15
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JR-Morgan
force-pushed
the
jrm/rhino-importer-retry
branch
from
60c007b to
0f34847
Compare
JR-Morgan
commented
Apr 16, 2026
JR-Morgan
commented
Apr 16, 2026
JR-Morgan
commented
Apr 16, 2026
Member
Author
|
currently live on latest + testing environments |
gjedlicska
approved these changes
Apr 20, 2026
JR-Morgan
added a commit
that referenced
this pull request
Apr 27, 2026
* fix(revit): apply accumulated transform to curves in linked DirectShapes (#1359) * fix(revit): apply accumulated transform to curves in linked DirectShape elements * refactor(revit): pre combine transforms for polylines * fix(revit): Lighting source material is included in the material quantities (#1361) * exclude default light source material * move the check inside TryAddMaterialPropertiesToQuantitiesDict as an early return * go simple * fix(revit): skip out-of-bounds snapping references for far-from-origin DirectShapes (#1362) * Chore: Update csharpier version and re-format (#1363) * Bump Csharpier * run csharpier format ./ * fix(plant3d): drawing name property * add drawing name prop * simplify * bring back comment * fix(acad, c3d, p3d): "Create New Model" pre-fills file name (#1368) * dev(.NET): Update repo to .NET 10.0.2xx SDK (#1360) * Fix new analysers * Bump csharpier * Bump build deps * fix bullseye changes * Fix tool changes * format again * regen locks * re-generate slnx * Format * typo * Readme * Allow dependencies to trickle down from SDK * Bump SDK * wraps rhino objects with data objects * adds properties * first pass of autocad dataobjects * receive rawEncoding * fix(rhino-importer): Fix rhino retrying already failed jobs (#1367) * Rhino retry changes * don't requeue if we can't report status. * move log to be clearer * fix * revit receive support * fix(revit): reject unimportable geometry cleanly with rollback (#1373) * fix(revit): reject unimportable geometry cleanly with rollback * chore(revit): csharpier --------- Co-authored-by: Mucahit Bilal GOKER <51519350+bimgeek@users.noreply.github.com> * fix(grasshopper): fix instance proxies now with rhino data object wrappers (#1374) * fix(rhino): duplicate ObjectAttributes per mesh in fallback group bake (#1375) * fix(rhino): restore material assignment * fix(rhino): use material name for legacy index lookup instead of RenderContent.FromId * chore: revert changes * fix(rhino): duplicate ObjectAttributes to prevent RenderMaterial ref bleed * adds attributes * format * bump sdk * feat: Default Server Url and other global config configurable via registry (#1376) * Url from global config * Fix binding data context * format * remove thing * revit registration fix * some defense * Supress otel cve (#1380) * feat(revit): adds SharedCoordinates as a reference point option (#1378) * feat(revit): split survey point into translation only and shared coordinates * chore: csharpier --------- Co-authored-by: Mucahit Bilal GOKER <51519350+bimgeek@users.noreply.github.com> --------- Co-authored-by: Oğuzhan Koral <45078678+oguzhankoral@users.noreply.github.com> Co-authored-by: Björn Steinhagen <88777268+bjoernsteinhagen@users.noreply.github.com> Co-authored-by: oguzhankoral <oguzhankoral@gmail.com> Co-authored-by: Mucahit Bilal GOKER <51519350+bimgeek@users.noreply.github.com> Co-authored-by: Dogukan Karatas <karatasdogukan@gmail.com> Co-authored-by: Dogukan Karatas <61163577+dogukankaratas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://linear.app/speckle/issue/CXPLA-482/investigate-rhino-importer-incorrect-re-queueing-behaviour
live and tested on latest + testing 3