feat(connectors): stop event listeners when cache disabled#1364
Draft
bjoernsteinhagen wants to merge 8 commits into
Draft
feat(connectors): stop event listeners when cache disabled#1364bjoernsteinhagen wants to merge 8 commits into
bjoernsteinhagen wants to merge 8 commits into
Conversation
…revent-stale-parameter-updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To discuss:
Changes:
DisableCache=true, theDocumentChangedevent isn't subscribed to at all — using the existing subscribe/unsubscribe pattern that was already there forDocumentChangeListeningDisabledOnModelObjectChangedRunExpirationChecksitself exits immediately and clears the accumulated IDsFrom my understanding: when cache is disabled, no object IDs are accumulated,
RunExpirationChecksnever runs,EvictObjectsis never called. The change tracking pipeline is a no-op.Testing: