Allows for multiface painting of meshes#1029
Draft
jsdbroughton wants to merge 3 commits intodevfrom
Draft
Conversation
Enhances handling of non-planar geometry by triangulating quads and n-gons. Implements more efficient material management and retrieval. Cleans up redundant code and improves overall maintainability.
…ent material use.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1029 +/- ##
=======================================
Coverage 41.20% 41.20%
=======================================
Files 109 109
Lines 3080 3080
Branches 293 293
=======================================
Hits 1269 1269
Misses 1765 1765
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is wonderful, Jonathon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: Discussion / RFC — Not for merge
Scope: Revit mesh conversion only. No changes to other hosts.
Enables per-face colouring by grouping faces by material and building geometry per material. This avoids Revit’s tendency to collapse mixed-material face sets into a single mesh with a single averaged colour.
Why
Revit meshes carry one MaterialElementId. A single connected build often “browns out” multi-material meshes. Building per material preserves face colours (e.g., Rhino → Speckle → Revit analysis/heatmap meshes).
How (high level)
Gating / Performance
This path is gated to avoid surprises on large models. Suggested modes:
What’s not included
Behaviour notes
Risks / Trade-offs
More geometry objects and more materials are enabled; costs scale with face count and unique colours. Hence the gating.
Questions