Skip to content

Added comparison between read and unread in Compact and Super Compact modes. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bannedbook wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added comparison between read and unread in Compact and Super Compact modes. #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/src/main/java/com/nononsenseapps/feeder/ui/compose/feed/FeedItemCard.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ import com.nononsenseapps.feeder.ui.compose.utils.PreviewThemes
import com.nononsenseapps.feeder.ui.compose.utils.onKeyEventLikeEscape
import java.net.URL
import java.time.Instant

import androidx.compose.ui.graphics.Color
import androidx.compose.material3.LocalContentColor
@Composable
fun FeedItemCard(
item: FeedListItem,
Expand Down Expand Up @@ -210,6 +211,12 @@ fun RowScope.FeedItemText(
}
}
val closeMenuText = stringResource(id = R.string.close_menu)
// The color of unread items remains unchanged, and the color of read items increases transparency
val titleColor = if (item.unread) {
Color.Unspecified // Use the default color and do not change the color of unread items
} else {
LocalContentColor.current.copy(alpha = 0.74f) //Increase transparency of read item color
}
Comment on lines +214 to +219

@spacecowboy spacecowboy Aug 19, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this should be moved inside the FeedListItemTitleTextStyle function in Typography.kt. See how the the font weight uses the unread flag:

fontWeight = titleFontWeight(item.unread)

Column(
verticalArrangement = Arrangement.spacedBy(4.dp),
modifier =
Expand All @@ -219,7 +226,7 @@ fun RowScope.FeedItemText(
WithBidiDeterminedLayoutDirection(paragraph = joinedText.text) {
Text(
text = joinedText,
style = FeedListItemTitleTextStyle(),
style = FeedListItemTitleTextStyle().copy(color = titleColor),
fontWeight = titleFontWeight(item.unread),
overflow = TextOverflow.Ellipsis,
maxLines = maxLines,
Expand Down