New setting to open article in browser instead of custom tab#1068
Open
xn-7492 wants to merge 6 commits into
Open
New setting to open article in browser instead of custom tab#1068xn-7492 wants to merge 6 commits into
xn-7492 wants to merge 6 commits into
Conversation
xn-7492
commented
Mar 16, 2026
xn-7492
commented
Contributor
- New setting to open article in browser instead of custom tab
- add 'Apply blocklist to summary' setting to opml import/export
4 tasks
Owner
|
Please don't do PRs for more than one change at a time. Split one of your changes out into its own PR |
This reverts commit eab4aef.
Contributor
Author
|
got it, i've moved the second change to a new pr |
spacecowboy
requested changes
Mar 22, 2026
spacecowboy
left a comment
spacecowboy
left a comment
Owner
There was a problem hiding this comment.
Technically, it seems fine.
But I don't like the phrasing Open items in reader. At this moment I don't have a much better suggestion though.
I feel that there is no way of knowing from the SettingsPage that this refers to the button in the menu bar 🤔
Contributor
Author
|
I have renamed it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.