Skip to content

Animal Spawner Reorganization + Xeno Spawners#36962

Merged
ArtisticRoomba merged 8 commits into
space-wizards:masterfrom
southbridge-fur:spawner-adjustments
May 15, 2025
Merged

Animal Spawner Reorganization + Xeno Spawners#36962
ArtisticRoomba merged 8 commits into
space-wizards:masterfrom
southbridge-fur:spawner-adjustments

Conversation

@southbridge-fur
Copy link
Copy Markdown
Contributor

@southbridge-fur southbridge-fur commented Apr 26, 2025 •
edited
Loading

About the PR

Reorganizes the mob spawners into their own respective files, and adds ones for Xenos since there weren't any before.

Why / Balance

  • The monolithic animals file was annoying to work with. Splitting these up helps a great deal.
  • Xeno spawners are good for salvage wrecks and ruins. There weren't any before and they're kind of needed.
  • Added suffixes to all the pets so everyone knows where they are supposed to go.
  • Also gave the hostile boxing kangaroo a suffix so nobody makes that mistake again of trying to map it instead of Willow.

Technical details

Yaml changes

Media

Nothing really to show

Requirements

Breaking changes

Changelog

no cl

@github-actions github-actions Bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Apr 26, 2025
@southbridge-fur southbridge-fur changed the title Spawner Reorganization Animal Spawner Reorganization Apr 26, 2025
@github-actions github-actions Bot added size/L Denotes a PR that changes 1000-4999 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Apr 26, 2025
This was referenced Apr 26, 2025
Closed
Closed
@lzk228
Copy link
Copy Markdown
Contributor

lzk228 commented Apr 26, 2025

i always didn't like spawner names, so i think it's time to suggest
i'd like to see names as spawner [thing], spawner random [thing]
but of course it needs discussion

@southbridge-fur
Copy link
Copy Markdown
Contributor Author

southbridge-fur commented Apr 27, 2025

Need to still make changes to this PR as requested in the original one

@southbridge-fur
Copy link
Copy Markdown
Contributor Author

southbridge-fur commented Apr 30, 2025

all previous changes requested have been done, this is ready to be reviewed and merged

@southbridge-fur southbridge-fur changed the title Animal Spawner Reorganization Animal Spawner Reorganization + Xeno Spawners Apr 30, 2025
@Errant-4 Errant-4 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 12, 2025
Errant-4
Errant-4 requested changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Errant-4 Errant-4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you paid attention to fix up the prototype layout and indentations, I am grateful! I did find a few stragglers though

Comment thread Resources/Prototypes/Entities/Markers/Spawners/Random/Mobs/xenos.yml Outdated
Comment thread Resources/Prototypes/Entities/Markers/Spawners/Mobs/pets.yml Outdated
Comment thread Resources/Prototypes/Entities/Markers/Spawners/Random/Mobs/xenos.yml Outdated
southbridge-fur and others added 3 commits May 12, 2025 22:36
@southbridge-fur @Errant-4
Update Resources/Prototypes/Entities/Markers/Spawners/Random/Mobs/xen…
4211ef7 
…os.yml

Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
@southbridge-fur @Errant-4
Update Resources/Prototypes/Entities/Markers/Spawners/Mobs/pets.yml
a1cb83f 
Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
@southbridge-fur @Errant-4
Update Resources/Prototypes/Entities/Markers/Spawners/Random/Mobs/xen…
2c40c95 
…os.yml

Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
@southbridge-fur
Copy link
Copy Markdown
Contributor Author

southbridge-fur commented May 13, 2025

I see that you paid attention to fix up the prototype layout and indentations, I am grateful! I did find a few stragglers though

done :3

@Errant-4 Errant-4 added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label May 13, 2025
@ArtisticRoomba ArtisticRoomba self-requested a review May 15, 2025 03:16
@ArtisticRoomba ArtisticRoomba merged commit 7e624d1 into space-wizards:master May 15, 2025
14 checks passed
@88tv 88tv mentioned this pull request Jul 20, 2025
Merged
2 tasks
@lzk228 lzk228 mentioned this pull request Aug 31, 2025
Merged
@NotLivyathan NotLivyathan mentioned this pull request Apr 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Errant-4 Errant-4 Errant-4 approved these changes

+1 more reviewer

@ArtisticRoomba ArtisticRoomba ArtisticRoomba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/L Denotes a PR that changes 1000-4999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@southbridge-fur @lzk228 @Errant-4 @ArtisticRoomba