feat: async transaction execution - #702
Open
MicaiahReid wants to merge 3 commits into
Open
Conversation
sendTransaction now validates and (unless skipPreflight) simulates the transaction up front, returning an error on failure. On success it dispatches the transaction to the execution engine and immediately returns the signature instead of blocking until execution completes, matching a real Solana node; clients fetch the result by signature once it has executed. To keep an accepted transaction from spuriously failing if its blockhash ages out during the asynchronous delay, blockhash recency is validated once at admission (ValidatedRecentBlockhashAtAdmission) and trusted at execution, while durable-nonce transactions still validate at execution (ValidateAtExecution). The admission-time checks honor the global --skip-signature-verification and --skip-blockhash-check escape hatches; skip_signature_verification is plumbed onto SurfnetSvm alongside skip_blockhash_check. The same change is propagated to the Jito bundle path, the block-production runloop, and the SDK.
getLatestBlockhash now returns the committed slot's blockhash together with a lastValidBlockHeight computed from that blockhash's actual age in the recent-blockhash window, instead of assuming a fixed MAX_RECENT_BLOCKHASHES offset. isBlockhashValid likewise uses the age-aware is_recent_blockhash_valid_for_processing check so an expired-by-age blockhash is correctly reported as invalid.
Adapts existing tests to the asynchronous, non-blocking sendTransaction (await the future, drop the join-handle wait) and adds coverage for: transactions and loader write batches surviving internal blockhash expiry, rejecting an invalid blockhash at admission, accepting an invalid blockhash when --skip-blockhash-check is set, honoring the global --skip-signature-verification flag at admission, is_blockhash_valid expiry-by-age, and the age-aware getLatestBlockhash response.
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1518
to
+1530
| let program_id = tx | ||
| .message | ||
| .static_account_keys() | ||
| .get(instruction.program_id_index as usize)?; | ||
| if !system_program::check_id(program_id) | ||
| || !is_advance_nonce_instruction_data(&instruction.data) | ||
| { | ||
| return None; | ||
| } | ||
|
|
||
| tx.message | ||
| .static_account_keys() | ||
| .get(*instruction.accounts.first()? as usize) |
Contributor
There was a problem hiding this comment.
For a v0 durable-nonce transaction, the nonce account index can refer to the resolved account list, but this helper only reads static_account_keys(). The RPC can then treat the transaction as non-nonce and use admission-only recent-blockhash validation, so a valid nonce transaction can be rejected with BlockhashNotFound or skip the nonce-account blockhash check.
Comment on lines
+1768
to
+1771
| #[cfg(feature = "prometheus")] | ||
| if let Some(m) = crate::telemetry::metrics() { | ||
| m.record_transaction(true, rpc_start.elapsed().as_millis() as u64); | ||
| m.record_rpc_request("sendTransaction", rpc_start.elapsed().as_millis() as u64); |
Contributor
There was a problem hiding this comment.
After enqueueing, the RPC drops the status receiver and records record_transaction(true, ...) before the runloop executes the transaction. A transaction that later fails execution is still counted as successful, so monitoring can show successful transaction processing while the stored transaction status contains an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.