Skip to content

Rely on casm debug info instead of libfunc names to exclude statements from coverage#258

Draft
piotmag769 wants to merge 1 commit into
mainfrom
rework-unreliable-libfuncs
Draft

Rely on casm debug info instead of libfunc names to exclude statements from coverage#258
piotmag769 wants to merge 1 commit into
mainfrom
rework-unreliable-libfuncs

Conversation

@piotmag769

Copy link
Copy Markdown

Closes #235

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@piotmag769 piotmag769 force-pushed the rework-unreliable-libfuncs branch from c3148de to 0c6fe12 Compare June 5, 2026 10:51
@piotmag769 piotmag769 force-pushed the rework-unreliable-libfuncs branch from 0c6fe12 to 0a89e53 Compare June 5, 2026 10:55
Comment on lines +74 to +76
fn does_compile_to_any_casm(&self, idx: StatementIdx) -> bool {
let debug_info = &self.casm_debug_info.sierra_statement_info[idx.0];
debug_info.start_offset != debug_info.end_offset

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the logical change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for better way of removing sierra statments, that are not present in casm

1 participant