fix: cast boolean threshold values to int before sending to Soda Cloud#2659
Merged
fix: cast boolean threshold values to int before sending to Soda Cloud#2659
Conversation
When a metric check uses a SQL query that returns a boolean (e.g. a comparison expression on Databricks), the raw Python bool flows through to `diagnostics.value` and gets serialized as JSON `true`/`false` instead of `1`/`0`. The backend expects a numeric value and rejects the payload with 400 "Could not parse request from json body". Cast bool to int in `_build_diagnostics_json_dict` so the serialized value is always numeric. Fixes SAS-11624
for more information, see https://pre-commit.ci
|
Niels-b
approved these changes
Apr 14, 2026
Contributor
Niels-b
left a comment
Niels-b
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking care of this one 🙌 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boolflows through todiagnostics.valueand gets serialized as JSONtrue/falseinstead of1/0booltointin_build_diagnostics_json_dictso the serialized value is always numericFixes SAS-11624
Test plan
True,False, numeric, zero, andNonethreshold values