Fix rubocop issues#286
Closed
jaredsmithse wants to merge 2 commits into
Closed
Conversation
Member
|
I agree with this, but I'll add it to ioquatix/bake-modernize@8127036#diff-f2367c12bc173597f3ab50b0543743f55bd77bde79a4f3f13c6ecbc1f63ef028 so it applies to all my code - as such, I'll do this in a separate commit as that process is automated. Thanks for bringing this to my attention and providing a good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the two Rubocop issues. The alternative was to exclude the
examples/folder, but it seemed appropriate to enforce consistency on*.rbfiles across examples. AddedLayout/EmptyLineAfterMagicCommentso that the autocorrect adds an empty line underneath as well (kept that in a separate commit in case you don't want it).Types of Changes
Contribution