You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Includes product update to be announced in the next stable release notes
What does this PR do?
Updates go-application-framework to include the fix for duplicate SARIF rules in UFM output. When multiple findings share the same problem ID (e.g., two generic-api-key secrets in different files), the SARIF output previously emitted one rule per finding, producing duplicate rule IDs in the rules array.
The update to github.com/snyk/go-application-framework aims to deduplicate SARIF rules. However, without visibility into the specific implementation of this deduplication in the upstream go-application-framework PR, there is a risk that the logic could be overly aggressive. This might lead to legitimate, unique SARIF rules being incorrectly identified as duplicates and subsequently omitted from the output, potentially causing information loss regarding detected issues. The manual testing instructions focus on verifying the absence of duplicates but do not explicitly ensure that all intended unique rules are still present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Updates
go-application-frameworkto include the fix for duplicate SARIF rules in UFM output. When multiple findings share the same problem ID (e.g., twogeneric-api-keysecrets in different files), the SARIF output previously emitted one rule per finding, producing duplicate rule IDs in therulesarray.Depends on: snyk/go-application-framework#583
Once the GAF PR is merged, this PR will be updated to point to the merged commit on main.
Where should the reviewer start?
This is a dependency-only update —
cliv2/go.modandcliv2/go.sum. The actual code changes are in the GAF PR.How should this be manually tested?
Run
snyk test --sarifagainst a repo with secrets findings that share the same rule ID and verify therulesarray contains no duplicates.What's the product update that needs to be communicated to CLI users?
None. This is a bug fix for SARIF output correctness.
Risk assessment (Low | Medium | High)?
Low — only updates a dependency version, no CLI code changes.
Any background context you want to provide?
The SARIF spec requires unique rule IDs in the
rulesarray. The fix deduplicates rules by problem ID while keeping all findings in theresultsarray.What are the relevant tickets?
CLI-1344