Repository navigation
SNOW-4554438: Add dedicated JDBC integration CI coverage - #4536
Draft
sfc-gh-yuwang wants to merge 1 commit into
Draft
sfc-gh-yuwang wants to merge 1 commit into
sfc-gh-yuwang wants to merge 1 commit into
Conversation
Run the JDBC suite independently against existing AWS datasource resources and reject skipped or incomplete coverage instead of reporting a green job. Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## yuwang/SNOW-4537767-jdbc-type-mapping #4536 +/- ##
======================================================================
Coverage 95.32% 95.33%
======================================================================
Files 179 179
Lines 47139 47139
Branches 8164 8164
======================================================================
+ Hits 44937 44939 +2
+ Misses 1361 1360 -1
+ Partials 841 840 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SNOW-4554438 (CI portion only). JDBC has a blanket Jenkins skip and currently shares GitHub datasource jobs with unrelated Python DBAPI drivers and earlier broad test steps. Add an independent daily/manual GitHub job that runs the JDBC suite against the existing AWS test account and four DBAPI sources, without removing the Jenkins skip or changing production behavior.
tox -e jdbcruns the entire module serially with a 180-second per-test timeout, first-failure stop, and no inherited selection flags. The workflow has a 30-minute bound, serializes its runs, and fails if the interpreter is missing.Stacked on #4530 (
yuwang/SNOW-4537767-jdbc-type-mapping, base3e33f580a). This PR contains only four CI/configuration/test files. SNOW-2089683 is DONE but has no description or comments establishing its root cause, so this does not claim Jenkins is repaired.Validation
actionlinton the new workflow.Repository pre-commit hooks on all four changed files (also passed during commit).
102 focused unit tests: 18 new report/CLI/workflow contract cases plus 84 existing datasource unit tests. Passed with both the existing interpreter and clean JDBC tox environment (pytest 7.4.4).
All 48 JDBC cases collect.
python -m tox run -e jdbc --notest --skip-missing-interpreters false: clean dependency resolution and package build succeed.Resolved tox config clears inherited
PYTEST_ADDOPTS=-k impossible --local_testing_mode.Full live
python -m tox run -e jdbc --skip-missing-interpreters false: 48 passed, zero skipped/failed/errors in 287.89s; JUnit checker passed and tox exited 0 (307.73s total). One existing unregistereddatasourcemarker warning. Uses existing local parameters (sfctest0,ACCOUNTADMIN), not GitHub credentials. An initial diagnostic invocation was stopped by its own 150-second outer cap after 21 passing cases; it was not a connection failure or a complete pass.Negative end-to-end check: setting
JENKINS_HOMEproduces 48 skipped cases; the actual checker CLI rejects that JUnit report with exit 1.Draft / infrastructure gates
Keep draft until the actual GitHub AWS credentials/role path is verified. The new workflow is not yet registered on the default branch (workflow API returns 404 while the existing daily workflow is accessible), so no new Actions run is claimed.
PARAMETER_PASSWORDdecrypts the existing AWS key, AWS connection parameters and DBAPI parameters on the runner; confirm Snowflake network/authentication policy permits that runner.SNOWPARK_DBAPI_*_TEST_INTEGRATIONEAIs, and read all fourADMIN.PUBLIC.SNOWPARK_DBAPI_*_TEST_CREDsecrets (including database/schema USAGE).Generated with Snowflake CoCo