Skip to content

SNOW-4554438: Add dedicated JDBC integration CI coverage - #4536

Draft
sfc-gh-yuwang wants to merge 1 commit into
yuwang/SNOW-4537767-jdbc-type-mappingfrom
yuwang/SNOW-4554438-jdbc-ci
Draft

sfc-gh-yuwang wants to merge 1 commit into
yuwang/SNOW-4537767-jdbc-type-mappingfrom
yuwang/SNOW-4554438-jdbc-ci

Conversation

@sfc-gh-yuwang

@sfc-gh-yuwang sfc-gh-yuwang commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

SNOW-4554438 (CI portion only). JDBC has a blanket Jenkins skip and currently shares GitHub datasource jobs with unrelated Python DBAPI drivers and earlier broad test steps. Add an independent daily/manual GitHub job that runs the JDBC suite against the existing AWS test account and four DBAPI sources, without removing the Jenkins skip or changing production behavior.

  • Python 3.11 tox -e jdbc runs the entire module serially with a 180-second per-test timeout, first-failure stop, and no inherited selection flags. The workflow has a 30-minute bound, serializes its runs, and fails if the interpreter is missing.
  • A JUnit gate requires at least the existing 48 unique JDBC cases and Oracle/PostgreSQL/MySQL/SQL Server smoke tests; skipped, failed, errored, missing, malformed, duplicate, or incomplete reports fail. Upload only the bounded JUnit artifact; remove decrypted credentials afterward.
  • Reuse the existing encrypted AWS key/parameters and DBAPI source parameters. No PR trigger, new credentials, local DBAPI drivers, local JVM, or persistent source provisioning. Schedule: 09:17 UTC daily after reaching the default branch; manual dispatch is for reviewed branches.

Stacked on #4530 (yuwang/SNOW-4537767-jdbc-type-mapping, base 3e33f580a). This PR contains only four CI/configuration/test files. SNOW-2089683 is DONE but has no description or comments establishing its root cause, so this does not claim Jenkins is repaired.

Validation

  • actionlint on the new workflow.

  • Repository pre-commit hooks on all four changed files (also passed during commit).

  • 102 focused unit tests: 18 new report/CLI/workflow contract cases plus 84 existing datasource unit tests. Passed with both the existing interpreter and clean JDBC tox environment (pytest 7.4.4).

  • All 48 JDBC cases collect.

  • python -m tox run -e jdbc --notest --skip-missing-interpreters false: clean dependency resolution and package build succeed.

  • Resolved tox config clears inherited PYTEST_ADDOPTS=-k impossible --local_testing_mode.

  • Full live python -m tox run -e jdbc --skip-missing-interpreters false: 48 passed, zero skipped/failed/errors in 287.89s; JUnit checker passed and tox exited 0 (307.73s total). One existing unregistered datasource marker warning. Uses existing local parameters (sfctest0, ACCOUNTADMIN), not GitHub credentials. An initial diagnostic invocation was stopped by its own 150-second outer cap after 21 passing cases; it was not a connection failure or a complete pass.

  • Negative end-to-end check: setting JENKINS_HOME produces 48 skipped cases; the actual checker CLI rejects that JUnit report with exit 1.

Draft / infrastructure gates

Keep draft until the actual GitHub AWS credentials/role path is verified. The new workflow is not yet registered on the default branch (workflow API returns 404 while the existing daily workflow is accessible), so no new Actions run is claimed.

  • Confirm PARAMETER_PASSWORD decrypts the existing AWS key, AWS connection parameters and DBAPI parameters on the runner; confirm Snowflake network/authentication policy permits that runner.
  • Verify the CI role can use the warehouse, create the test schema/functions/stage, run shared fixture integration/artifact-repository setup, use all four SNOWPARK_DBAPI_*_TEST_INTEGRATION EAIs, and read all four ADMIN.PUBLIC.SNOWPARK_DBAPI_*_TEST_CRED secrets (including database/schema USAGE).
  • Verify existing source tables/data and run all 48 cases with zero skips on the GitHub runner, retaining its JUnit artifact. Local ACCOUNTADMIN results do not establish CI-role grants. Schedule/manual triggers require the workflow to be available on the default branch; this PR does not merge or alter account grants.
  • The separate jdbc-vs-dbapi-UDTF GA performance baseline remains outstanding: 1M and 10M rows for every vendor using the existing perf harness. No tiny dataset results are substituted and this PR does not close the full ticket.

Generated with Snowflake CoCo

Run the JDBC suite independently against existing AWS datasource resources and reject skipped or incomplete coverage instead of reporting a green job.

Generated with [Snowflake CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-authored-by: Snowflake CoCo <noreply@snowflake.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.33%. Comparing base (3e33f58) to head (d098cf4).
⚠️ Report is 1 commits behind head on yuwang/SNOW-4537767-jdbc-type-mapping.

Additional details and impacted files
@@                          Coverage Diff                           @@
##           yuwang/SNOW-4537767-jdbc-type-mapping    #4536   +/-   ##
======================================================================
  Coverage                                  95.32%   95.33%           
======================================================================
  Files                                        179      179           
  Lines                                      47139    47139           
  Branches                                    8164     8164           
======================================================================
+ Hits                                       44937    44939    +2     
+ Misses                                      1361     1360    -1     
+ Partials                                     841      840    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants