Skip to content

SNOW-3960822: skip test_sample_with_sampling_method on stored proc localfs - #4318

Merged
sfc-gh-bkogan merged 2 commits into
mainfrom
bkogan/SNOW-3960822-skip-sample-sampling-method-localfs-sp
Aug 18, 2026
Merged

sfc-gh-bkogan merged 2 commits into
mainfrom
bkogan/SNOW-3960822-skip-sample-sampling-method-localfs-sp

Conversation

@sfc-gh-bkogan

@sfc-gh-bkogan sfc-gh-bkogan commented Aug 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Skip test_sample_with_sampling_method when running inside a stored proc on local-disk storage (IS_IN_STORED_PROC_LOCALFS), matching test_sample_with_frac and test_sample_with_row_count in the same file.
  • A 10k-row .collect() can spill past GS's first result chunk (~97KB). On LIGHTWEIGHT/localfs, extra chunks use /queries/download-result URLs that Python stored procs do not support, which flakes SNOW-3960822.
  • The durable server-side fix is SNOW-3967582 (support localfs result-chunk URLs in stored procs). That is not on the near-term radar, so this skip unblocks BPTP until then.

Test plan

  • Confirm the decorator matches the existing IS_IN_STORED_PROC_LOCALFS / "Large result" skips in tests/integ/scala/test_dataframe_suite.py.
  • After this ships into the Snowfort staged snowpark tests, SNOW-3960822 should stop failing on REG_LIGHTWEIGHT. The test still runs as a normal client integ test and still runs in stored procs on local AWS / remote.

…calfs

A 10k-row collect can spill past the first result chunk, and Python stored
procs cannot fetch download-result URLs on local-disk SUTs. Match the skip
already used by the sibling sample tests.
@sfc-gh-bkogan sfc-gh-bkogan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 17, 2026
@sfc-gh-bkogan
sfc-gh-bkogan marked this pull request as ready for review August 17, 2026 21:13
@sfc-gh-bkogan
sfc-gh-bkogan requested a review from a team as a code owner August 17, 2026 21:13

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

@codecov-commenter

codecov-commenter commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.24%. Comparing base (6f88fc5) to head (dd4a238).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4318   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files         171      171           
  Lines       44720    44720           
  Branches     7676     7676           
=======================================
  Hits        42593    42593           
  Misses       1340     1340           
  Partials      787      787           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

@sfc-gh-bkogan
sfc-gh-bkogan merged commit 6ab27ed into main Aug 18, 2026
28 of 31 checks passed
@sfc-gh-bkogan
sfc-gh-bkogan deleted the bkogan/SNOW-3960822-skip-sample-sampling-method-localfs-sp branch August 18, 2026 17:17
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants