Repository navigation
SNOW-3923354 decouple pandas version from python connector and support pandas 3.x #4312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 20 commits
051402b
115ef72
de8567e
e4bda40
2438471
3c4e30f
e577c41
06f3cc3
975ddf6
f978573
85bdce9
9b5a9bc
721986c
01c2c17
8bae44d
2897230
8d57a6d
9c43219
666a198
cf9a8eb
a31458f
c409453
8aa19c0
4c14a3c
76bc2a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1937,6 +1937,12 @@ def get_sorted_key_for_version(version_str): | |
| ) | ||
|
|
||
|
|
||
| # Use this for pandas 2 vs 3 branches instead of parsing __version__ inline. | ||
| pandas_major_version = ( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it appears that this is not imported anywhere in this PR, do we really need it?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the suggestion! This was imported but eventually fall back to the inline format after consideration. Already removed in the following commits. |
||
| get_sorted_key_for_version(str(pandas.__version__))[0] if installed_pandas else 0 | ||
| ) | ||
|
|
||
|
|
||
| def ttl_cache(ttl_seconds: float): | ||
| """ | ||
| A decorator that caches function results with a time-to-live (TTL) expiration. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand correctly, we add pyarrow here because we get rid of the [pandas] constraint?
If that is the case, do we need to align the pyarrow limit with connector? Like I remember they have a lower limit for pyarrow> xxx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we previously relied on connector side which has pyarrow imported in its
[pandas]extra.Applied the same constraint mirroring with connector's side now.