Merged
Conversation
This is to ensure that the function being tested is symmetric in its arguments, which is a common expectation for equality checks.
Author
|
I feel like your code is fine in fact, so me tests could be merged, and then they would appear in your PR |
There was a problem hiding this comment.
Pull request overview
This PR expands the assert package’s equality helper tests to cover additional floating-point edge cases and to enforce symmetry of comparisons.
Changes:
- Add
NaN,Inf, and signed-zero (-0) cases toTestObjectsAreEqual. - Add more float32/float64 edge cases (near-overflow,
NaN,Inf, signed zero) toTestObjectsAreEqualValues. - Add symmetry assertions to both equality test suites to ensure
f(a, b) == f(b, a).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.