You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to piece things together so we could rebase and merge this PR prior to the upcoming release. I'm not aiming for full support of split-domain setups in this release, but I'd like to make any small safe steps that we can towards it. This seems like one!
I see that SNIKKET_TWEAK_CERT_DOMAIN is being pulled from SNIKKET_TWEAK_XMPP_DOMAIN. But in the case of a split-domain setup, we want nginx to have certs for the web domain, right?
I have forgotten some of what I wrote back then but you are correct. If SNIKKET_TWEAK_XMPP_DOMAIN is set, the jids are of the form user@SNIKKET_TWEAK_XMPP_DOMAIN and the web portal is still hosted on SNIKKET_DOMAIN. This means that certificates for SNIKKET_DOMAIN should be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web proxy extension of snikket-im/snikket-server#69