Update Solana off-chain codec#1539
Open
huangzhen1997 wants to merge 6 commits into
Open
Conversation
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
product-security-plaid-production
Bot
requested review from
DylanTinianov,
Farber98,
Krish-vemula,
Unheilbar,
amit-momin,
archseer,
dhaidashenko,
fernandezlautaro,
ilija42,
prashantkumar1982,
silaslenihan and
yashnevatia
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
commented
Apr 22, 2026
|
|
||
| func parseExtraDataMap(input map[string]any) (extraData, error) { | ||
| // ParseExtraDataMap parses the decoded extra args map into the extraData struct used for encoding the execute report. | ||
| func ParseExtraDataMap(input map[string]any) (ExtraData, error) { |
Contributor
Author
There was a problem hiding this comment.
This change comes from a previous fix from core.
Collaborator
There was a problem hiding this comment.
Ah I see it's moved here
Contributor
✅ API Diff Results -
|
huangzhen1997
changed the title
huangzhen1997
had a problem deploying
to
integration
GitHub Actions
Error
huangzhen1997
had a problem deploying
to
integration
GitHub Actions
Error
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
archseer
reviewed
Apr 22, 2026
| return [32]byte{}, fmt.Errorf("failed to decode dest exec data: %w", err) | ||
| } | ||
|
|
||
| destGasAmount, err := extractDestGasAmountFromMap(destExecDataDecodedMap) |
Collaborator
There was a problem hiding this comment.
Are there no more changes to backport into this file? The msghasher in core looks completely different
|
|
||
| func parseExtraDataMap(input map[string]any) (extraData, error) { | ||
| // ParseExtraDataMap parses the decoded extra args map into the extraData struct used for encoding the execute report. | ||
| func ParseExtraDataMap(input map[string]any) (ExtraData, error) { |
Collaborator
There was a problem hiding this comment.
Ah I see it's moved here
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
|
huangzhen1997
temporarily deployed
to
integration
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://smartcontract-it.atlassian.net/browse/NONEVM-4683
Related PR: smartcontractkit/chainlink#22124
The idea is to remove duplicate Solana codec code in core, and import it from chainlink-solana instead.