CRE-4343/CRE-4352: Add mtls support in OutboundHTTPRequest + feature …#2067
Open
cedric-cordenier wants to merge 2 commits into
Open
CRE-4343/CRE-4352: Add mtls support in OutboundHTTPRequest + feature …#2067cedric-cordenier wants to merge 2 commits into
cedric-cordenier wants to merge 2 commits into
Conversation
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds mTLS client-credential support to OutboundHTTPRequest (private key + certificate) and introduces a per-org feature flag MtlsAuthAllowed to gate the new capability via the cresettings system.
Changes:
- Add
MtlsAuth(with a redactingSecrettype) toOutboundHTTPRequest, and include it inHash(). - Add new
PerOrg.HTTPAction.MtlsAuthAllowedsetting with defaultfalse, wired into schema/defaults files. - Add hash-related unit tests for the new mTLS field.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/gateway/action.go | Adds Secret, MtlsAuth types, new Mtls field, and hash inclusion. |
| pkg/types/gateway/action_test.go | New hash tests covering Mtls equality, nil vs non-nil, and byte-shift cases. |
| pkg/settings/cresettings/settings.go | Adds perOrgHTTPAction with MtlsAuthAllowed; fixes alignment of existing fields. |
| pkg/settings/cresettings/settings_test.go | Whitespace/indentation fix on existing line. |
| pkg/settings/cresettings/README.md | Adds new gate node to the mermaid diagram. |
| pkg/settings/cresettings/defaults.toml | Adds [PerOrg.HTTPAction] section with default. |
| pkg/settings/cresettings/defaults.json | Adds matching HTTPAction.MtlsAuthAllowed default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cedric-cordenier
force-pushed
the
CRE-4343-add-mtls-types
branch
2 times, most recently
from
3915a8d to
1aeadf2
Compare
cedric-cordenier
force-pushed
the
CRE-4343-add-mtls-types
branch
from
1aeadf2 to
8cfc841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…flag for mtls
Requires
Supports